deps: QueryFarm.VgiRpc 0.11.1 — the Arrow writer keeps a batch alive until it is written - #9
Merged
Merged
Conversation
…until it is written vgi-rpc-csharp 0.11.1 ships QueryFarm.Arrow 23.0.0-queryfarm.3, which fixes at its source the use-after-free 7b8d615 worked around here: ArrowStreamWriter dropped its reference to the batch before copying the buffer bodies, so a batch built only to be written could have its SharedMemoryHandles finalized mid-write. RecordBatchIpc.Write keeps its GC.KeepAlive as defence in depth. 0.11.0's removals (introspection rate limiting, the __introspect_token__ route, TokenIntrospection, AuthUnavailableException) are unused here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all three QueryFarm.VgiRpc pins from 0.10.2 to 0.11.1.
0.11.1 ships QueryFarm.Arrow 23.0.0-queryfarm.3, which fixes the Arrow .NET writer use-after-free at its source. That is the bug 7b8d615 worked around here:
ArrowStreamWriterdropped its reference to the batch before copying the buffer bodies, so a batch built only to be written could have itsSharedMemoryHandles finalized mid-write. The symptom was an intermittent NRE inWriteBufferData, or a silent copy of memory the pool had already reused.RecordBatchIpc.Writekeeps itsGC.KeepAliveas defence in depth.0.11.0's removals don't affect this repo; a grep found no uses:
__introspect_token__routeTokenIntrospectionAuthUnavailableExceptionAdds a
MUST be >= 0.11.1correctness-floor note next to the existing ones inDirectory.Packages.props.🤖 Generated with Claude Code