Skip to content

chore: restore frontend quality gates - #20

Merged
QueryPlanner merged 3 commits into
mainfrom
codex/frontend-quality-gates
Aug 4, 2026
Merged

chore: restore frontend quality gates#20
QueryPlanner merged 3 commits into
mainfrom
codex/frontend-quality-gates

Conversation

@QueryPlanner

@QueryPlanner QueryPlanner commented Aug 4, 2026

Copy link
Copy Markdown
Owner

What

Restore a green, deterministic frontend validation baseline before implementing issues #16 and #17.

Why

The frontend lint command failed on the existing source, and the repository had no component-test or pull-request validation workflow. The upcoming Spotify export, playlist-length, and continuous-playback work needs independent automated gates.

How

  • Add React 19-compatible Vitest, Testing Library, jsdom, and V8 coverage tooling.
  • Preserve the existing SEO suite and run it alongside 14 component and helper tests.
  • Enforce 100% coverage for the newly extracted callback and YouTube-resolution helpers.
  • Add read-only frontend CI for frozen install, lint, typecheck, coverage, and production build.
  • Fix existing Next.js font, callback, hooks, and Recharts typing violations.
  • Guard OAuth Strict Mode replay and stale YouTube request lifecycles with regression tests.
  • Render failed YouTube lookups as unavailable with an explicit retry action.

Tests

  • CI=true pnpm install --frozen-lockfile
  • pnpm lint
  • pnpm typecheck
  • pnpm test:coverage — 6 SEO tests and 15 unit tests; scoped helpers at 100%
  • pnpm build
  • Luna blocker re-review — approved with no actionable findings

Related Issues

Prerequisite for #16 and #17. This PR does not close either feature issue.

- Add deterministic lint, typecheck, test, and build CI
- Add component tests and fully cover extracted helpers
- Fix Next.js, hooks, and Recharts lint failures
- Guard OAuth and YouTube async lifecycle regressions
@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
true-random-songs Ready Ready Preview Aug 4, 2026 8:02am

@QueryPlanner
QueryPlanner marked this pull request as ready for review August 4, 2026 07:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55fe17392f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/app/layout.tsx Outdated
- Expose the Next.js Capriola font through a CSS variable
- Use the generated font for explicit global style rules
- Add a regression test for the font wiring
@QueryPlanner

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c10e13d5c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/app/page.tsx
- Track failed YouTube lookups separately from active requests
- Render unavailable state with an explicit retry action
- Cover failed, retry, and service-switch behavior
@QueryPlanner
QueryPlanner merged commit 02c1cf0 into main Aug 4, 2026
4 checks passed
@QueryPlanner
QueryPlanner deleted the codex/frontend-quality-gates branch August 4, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant