chore: restore frontend quality gates - #20
Conversation
- Add deterministic lint, typecheck, test, and build CI - Add component tests and fully cover extracted helpers - Fix Next.js, hooks, and Recharts lint failures - Guard OAuth and YouTube async lifecycle regressions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55fe17392f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Expose the Next.js Capriola font through a CSS variable - Use the generated font for explicit global style rules - Add a regression test for the font wiring
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c10e13d5c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Track failed YouTube lookups separately from active requests - Render unavailable state with an explicit retry action - Cover failed, retry, and service-switch behavior
What
Restore a green, deterministic frontend validation baseline before implementing issues #16 and #17.
Why
The frontend lint command failed on the existing source, and the repository had no component-test or pull-request validation workflow. The upcoming Spotify export, playlist-length, and continuous-playback work needs independent automated gates.
How
Tests
CI=true pnpm install --frozen-lockfilepnpm lintpnpm typecheckpnpm test:coverage— 6 SEO tests and 15 unit tests; scoped helpers at 100%pnpm buildRelated Issues
Prerequisite for #16 and #17. This PR does not close either feature issue.