fix(qwik-vite): keep reachable deps when reducing cyclic bundle graphs - #8789
Draft
briancarbone wants to merge 1 commit into
Draft
fix(qwik-vite): keep reachable deps when reducing cyclic bundle graphs#8789briancarbone wants to merge 1 commit into
briancarbone wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: ecbce59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maiieul
reviewed
Jul 2, 2026
maiieul
left a comment
maiieul
left a comment
Member
There was a problem hiding this comment.
Nice! I removed this in my Vite 8 PR because that led to the same bug you faced I think. Your solution is better because it's more performant. Can you trim/remove the unnecessary comments and only keep what's critical to understand the code?
briancarbone
force-pushed
the
fix/bundle-graph-cyclic-deps
branch
from
July 2, 2026 19:23
2bb8a40 to
0553175
Compare
Contributor
Author
|
Should be better now |
briancarbone
force-pushed
the
fix/bundle-graph-cyclic-deps
branch
2 times, most recently
from
July 2, 2026 19:36
98fbef5 to
0553175
Compare
Per-bundle transitive reduction severed covering paths that ran back through import cycles, collapsing cyclic bundles to zero preload deps (a cold-nav chunk waterfall). Reduce via SCC condensation instead (shared condenseImportGraph, also reused by computeTotals), so an import cycle can't drop a still-reachable dependency. Regression test: an x->a->x cycle keeps both a.js and d.js as deps of x.
briancarbone
force-pushed
the
fix/bundle-graph-cyclic-deps
branch
from
July 2, 2026 19:38
0553175 to
ecbce59
Compare
briancarbone
marked this pull request as draft
July 3, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.