fix: avoid serializing computed signal values by default - #8860
Open
Varixo wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: e067928 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
serializationStrategy: 'always', which caused evaluated computed values to be written into the SSR-embeddedqwik/stateand risked leaking server-only or sensitive derived data.alwaysdefault for async signals.Description
getComputedSignalFlags(options?.serializationStrategy || 'never')so computed signals default toneverwhen no explicitserializationStrategyis provided (packages/qwik/src/core/reactive-primitives/signal-api.ts).always(packages/qwik/src/core/reactive-primitives/signal-api.ts).SerializationStrategydocumentation to explicitly distinguish that computed signals default toneverand async signals default toalways(packages/qwik/src/core/shared/types.ts).always-configured computed still does, and updated the inline snapshot accordingly (packages/qwik/src/core/shared/serdes/serdes.unit.ts).@qwik.dev/core(.changeset/calm-computed-secrets.md).Testing
pnpm dlx @intellectronica/ruler@0.3.42 apply --no-gitignore --no-mcpwas attempted and failed in this environment due to a registry403(environmental artifact, not related to the code change).pnpm build.core.devcompleted successfully and produced the development build artifacts.pnpm vitest run packages/qwik/src/core/shared/serdes/serdes.unit.ts -t "ComputedSignal" --reporter=verboseand the failing snapshot was updated to reflect the new default; the focused run passed after the update.pnpm vitest run packages/qwik/src/core/shared/serdes/serdes.unit.ts --reporter=verboseand completed with all tests in that file passing.git diff --check) were run as part of the verification and reported no problems with the modified files.Codex Task