Fix quickstart dependency resolution and CLI test compatibility - #46
Closed
moonandlife wants to merge 7 commits into
Closed
Fix quickstart dependency resolution and CLI test compatibility#46moonandlife wants to merge 7 commits into
moonandlife wants to merge 7 commits into
Conversation
added 7 commits
April 2, 2026 21:36
…e in CI python-jose, passlib, aiofiles, configparser, markdown, pydantic-settings, and structlog were in the [full] optional extras but are hard-imported by services/auth_service.py at module level. This caused 7 collection errors when running pytest with only [dev] installed (no [full]). - Move those packages to core dependencies - Keep only isage-sias in [full] (genuinely optional) - Update both CI install steps to pip install -e '.[dev,full]'
…ject.toml changes Ensures pip cache is cleared when dependencies change, preventing stale cached packages from being used in CI runs.
Force fresh package downloads to ensure python-jose and other dependencies are properly installed, bypassing pip's internal package cache.
The PYTHONPATH=src setting makes sage.studio source importable without pip, but private SAGE packages (isage, isagellm, etc.) are not on public PyPI, causing pip install -e '.[dev]' to fail silently. This means none of the declared dependencies (including python-jose) ever get installed. Fix: - Allow pip install -e '.[dev]' to fail gracefully (|| true) - Add explicit install step for all runtime deps needed by unit tests (python-jose, passlib, fastapi, pydantic, etc.)
Root cause: pip install -e '.[dev]' installs dev extras fine (pytest works) but core deps with private packages (isage, isagellm) may not resolve on public CI, so python-jose (in core) never gets installed. Fix: - Add python-jose, passlib, aiofiles, pydantic-settings, structlog directly to dev extras so they always install alongside pytest - Add 'Verify key dependencies' step to fail fast with a clear message if any critical import is missing before tests run
Previous approach: pip install -e '.[dev]' silently fails when private packages (isage-pypi-publisher, isage, isagellm etc.) are unavailable on public PyPI. pip's dependency resolver aborts the entire extras install, so python-jose never gets installed. New approach: 1. Create requirements-ci.txt with ONLY public PyPI packages needed by tests 2. Install via 'python -m pip install -r requirements-ci.txt' as the FIRST step - this bypasses pyproject.toml and private package resolution entirely 3. Verify key imports immediately after to fail fast with a clear error 4. Try 'pip install -e .[dev]' as best-effort after (|| true)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation