[WS2][PR7][Attention] Add FlashInfer RoPE-fused paged attention scaffold - #279
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Open
8 tasks
inaniloquentee
force-pushed
the
codex/ws2-pr7-flashinfer-rope-fused-submit
branch
from
August 5, 2026 15:28
aaf1b4b to
ed157ab
Compare
Signed-off-by: inaniloquentee <3051000145@qq.com>
inaniloquentee
force-pushed
the
codex/ws2-pr7-flashinfer-rope-fused-submit
branch
from
August 5, 2026 15:59
ed157ab to
b69859e
Compare
inaniloquentee
marked this pull request as ready for review
August 12, 2026 15:21
inaniloquentee
requested review from
EthanZero2Hero,
Flink-ddd and
KJLdefeated
as code owners
August 12, 2026 15:21
inaniloquentee
changed the base branch from
feat/ws2-attention-single-gpu-harness-pr2
to
test
August 12, 2026 16:13
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
inaniloquentee
force-pushed
the
codex/ws2-pr7-flashinfer-rope-fused-submit
branch
from
August 17, 2026 12:58
aa74b78 to
6f4aeed
Compare
Signed-off-by: lamentropetion <3051000145@qq.com>
inaniloquentee
force-pushed
the
codex/ws2-pr7-flashinfer-rope-fused-submit
branch
from
August 17, 2026 13:21
6f4aeed to
8309b77
Compare
This was referenced Aug 17, 2026
…live # Conflicts: # ci/run_gpu_ci.sh # rl_engine/testing/__init__.py
maxiaosong1124
self-requested a review
August 24, 2026 16:11
maxiaosong1124
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
PR7 is the CUDA paged-KV adapter and strict production Attention entry point for #235. FlashInfer remains the cache-layout adapter; strict Attention arithmetic now reuses the qualified FA4 CuTe core instead of the RL-Kernel reference core.
flash_attn.cute.interface.flash_attn_funcnum_splits=1deterministic=true0; deterministic backward requiredpack_gqafixed from head layout;return_lse=truecuda_ag_rsThe loader inspects the installed FA4 CuTe signature and fails closed when
num_splits, deterministic backward, GQA packing, or LSE export controls are absent. There is no silent fallback to another Attention kernel.Q/K RMSNorm and projection policy are supplied by #230: TE Q/K RMSNorm is reused after an exact probe; QKV/O projection stays on RL-Kernel deterministic GEMM because expanded vendor GEMM probes drifted.
Validation
Current head:
044f5b1.172 passed, 741 skipped58 passed, 129 skippednum_splits=1, deterministic backward, FP32 LSE, production/reference identity checksPrevious H100 results for the RL-Kernel deterministic core remain reference evidence only. They are not presented as FA4 current-head acceptance. Production bitwise status requires rerunning prefill/decode, B=1/B>1, representative sequence lengths, and 2/4/8-rank CUDA AG+RS on this exact head.
Reproduce
Related to #235 and #294.