[WS2][Logp] Expose the lse_vocab_tile_reduction ablation switch on linear-logp ops - #317
Open
zhangj1an wants to merge 1 commit into
Open
Conversation
zhangj1an
requested review from
EthanZero2Hero,
Flink-ddd,
KJLdefeated and
inaniloquentee
as code owners
August 17, 2026 15:36
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zhangj1an
force-pushed
the
jian/logp-lse-vocab-tile-reduction-switch
branch
from
August 17, 2026 15:41
4d714d0 to
84b1738
Compare
zhangj1an
force-pushed
the
jian/logp-lse-vocab-tile-reduction-switch
branch
from
August 17, 2026 16:04
84b1738 to
5a2f048
Compare
The WS2 mismatch matrix addresses switches by dotted path. Take `logp.lse_vocab_tile_reduction` as a keyword-only argument on all three linear-logp backends so the driver can reach it whichever one the registry resolves to on a given device. Per call rather than per instance: `KernelRegistry` caches op instances for the life of the process, so an attribute would leak one ablation arm's setting into every later call. Interface only: the argument defaults to `original`, the per-shard merge these ops already do, so behaviour is unchanged. `fixed` raises rather than falling back, which would make the matrix report the factor as irrelevant. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TGgEEbTcLRZjwePXJztT9S
zhangj1an
force-pushed
the
jian/logp-lse-vocab-tile-reduction-switch
branch
from
August 18, 2026 13:06
5a2f048 to
775a364
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple API to turn on or off deterministic LSE vocab reduction order for logprob ops. Follows @KJLdefeated's design in PR #314.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TGgEEbTcLRZjwePXJztT9S