Skip to content

fix(integrations): restore strict Qwen3 bitwise parity - #339

Open
inaniloquentee wants to merge 1 commit into
testfrom
codex/issue335-bitwise-runtime
Open

fix(integrations): restore strict Qwen3 bitwise parity#339
inaniloquentee wants to merge 1 commit into
testfrom
codex/issue335-bitwise-runtime

Conversation

@inaniloquentee

Copy link
Copy Markdown
Collaborator

Summary

  • add the strict FA4 BSHD entrypoint plus bundled-vLLM FA4/rotary compatibility
  • align Megatron and vLLM Attention projections on DetGemmOp and match Megatron's RMSNorm arithmetic
  • replace every duplicate sampled-token logprob column before vLLM response conversion

Validation

  • python -m pytest -q tests/test_framework_runtime_adapters.py tests/test_flashinfer_pr7_attention.py: 77 passed, 1 skipped
  • 8x H100, Qwen3-8B Dense, TP=2, CP=2, 128 response tokens, debug environment variables unset:
    • train_rollout_logprob_abs_diff: 0.0
    • mismatch_count: 0 / 128
    • max_abs_diff: 0.0

The validation job subsequently hits Vime/Megatron's existing distributed optimizer checkpoint assertion (torch.Size([]), 0, 311427072), after the strict consistency metric has passed.

Fixes #335

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 97a29115-1913-4926-8dac-0185368841b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Flink-ddd Flink-ddd added the platform: cuda Specific optimizations or bugs in NVIDIA graphics cards (such as FlashInfer, TMA optimizations) label Aug 25, 2026

@Flink-ddd Flink-ddd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: cuda Specific optimizations or bugs in NVIDIA graphics cards (such as FlashInfer, TMA optimizations)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants