Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4899 +/- ##
===========================================
- Coverage 92.89% 92.80% -0.09%
===========================================
Files 585 589 +4
Lines 30189 30382 +193
===========================================
+ Hits 28042 28195 +153
- Misses 2147 2187 +40
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To provide a stable set of operators to external tools like torch_migraphx through the op builder(or macro) interface.
Technical Details
This creates a "kit" which is a collection of op builders that essentially are wrappers around our current operators or op builders which all have a namespace(like
tm::for this case). If change or remove operators then we can update the kit to use some kind of op builder to achieve the same behavior.Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable