Skip to content

Add torch kit#4899

Draft
pfultz2 wants to merge 5 commits into
developfrom
torch-kit
Draft

Add torch kit#4899
pfultz2 wants to merge 5 commits into
developfrom
torch-kit

Conversation

@pfultz2
Copy link
Copy Markdown
Collaborator

@pfultz2 pfultz2 commented May 20, 2026

Motivation

To provide a stable set of operators to external tools like torch_migraphx through the op builder(or macro) interface.

Technical Details

This creates a "kit" which is a collection of op builders that essentially are wrappers around our current operators or op builders which all have a namespace(like tm:: for this case). If change or remove operators then we can update the kit to use some kind of op builder to achieve the same behavior.

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 47.05882% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/op/builder/torch_kit.cpp 28.00% 18 Missing ⚠️
src/op/builder/include/migraphx/op/builder/kit.hpp 77.27% 5 Missing ⚠️
src/op/builder/op_builder.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4899      +/-   ##
===========================================
- Coverage    92.89%   92.80%   -0.09%     
===========================================
  Files          585      589       +4     
  Lines        30189    30382     +193     
===========================================
+ Hits         28042    28195     +153     
- Misses        2147     2187      +40     
Files with missing lines Coverage Δ
...builder/include/migraphx/op/builder/op_builder.hpp 81.48% <ø> (+3.70%) ⬆️
src/op/builder/op_builder.cpp 64.71% <0.00%> (-8.63%) ⬇️
src/op/builder/include/migraphx/op/builder/kit.hpp 77.27% <77.27%> (ø)
src/op/builder/torch_kit.cpp 28.00% <28.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pfultz2 pfultz2 requested a review from shivadbhavsar May 20, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant