Skip to content

fix: disable EP topk-1 strip#3771

Open
JiaoliangYu wants to merge 1 commit into
ROCm:mainfrom
JiaoliangYu:debug/no-ep-topk-strip
Open

fix: disable EP topk-1 strip#3771
JiaoliangYu wants to merge 1 commit into
ROCm:mainfrom
JiaoliangYu:debug/no-ep-topk-strip

Conversation

@JiaoliangYu

Copy link
Copy Markdown

Motivation

DSv4 with mori ep topk_ids has no fake slot, "topk-1" cause tuned-config miss.

As long as EP always goes through mori, dropping the topk -= int(is_ep) strip is correct.

Technical Details

Test Plan

Test Result

Submission Checklist

@JiaoliangYu JiaoliangYu requested a review from a team June 17, 2026 07:06
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 3771 --add-label <label>

@JiaoliangYu JiaoliangYu force-pushed the debug/no-ep-topk-strip branch from 27d0419 to c4a2167 Compare June 18, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant