[Triton] Detect rocm-core version via rpm on RPM-based systems#3775
Open
mengfei-jiang wants to merge 3 commits into
Open
[Triton] Detect rocm-core version via rpm on RPM-based systems#3775mengfei-jiang wants to merge 3 commits into
mengfei-jiang wants to merge 3 commits into
Conversation
dpkg only works on Debian/Ubuntu. Fall back to
`rpm -q --queryformat '%{VERSION}' rocm-core` so ROCm version detection
also works on RHEL/openEuler-style images
(e.g. rocm-core-7.2.0.70200-43.el8.x86_64 -> 7.2.0.70200 -> 7.2).
Applied to both install_triton.sh and download_triton_wheel.sh.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpkg only works on Debian/Ubuntu. Fall back to
rpm -q --queryformat '%{VERSION}' rocm-coreso ROCm version detection also works on RHEL/openEuler-style images(e.g. rocm-core-7.2.0.70200-43.el8.x86_64 -> 7.2.0.70200 -> 7.2).
Applied to both install_triton.sh and download_triton_wheel.sh.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist