Skip to content

[Triton] Detect rocm-core version via rpm on RPM-based systems#3775

Open
mengfei-jiang wants to merge 3 commits into
mainfrom
fix/rocm-core-rpm-detection
Open

[Triton] Detect rocm-core version via rpm on RPM-based systems#3775
mengfei-jiang wants to merge 3 commits into
mainfrom
fix/rocm-core-rpm-detection

Conversation

@mengfei-jiang

Copy link
Copy Markdown
Contributor

dpkg only works on Debian/Ubuntu. Fall back to
rpm -q --queryformat '%{VERSION}' rocm-core so ROCm version detection also works on RHEL/openEuler-style images
(e.g. rocm-core-7.2.0.70200-43.el8.x86_64 -> 7.2.0.70200 -> 7.2).

Applied to both install_triton.sh and download_triton_wheel.sh.

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

dpkg only works on Debian/Ubuntu. Fall back to
`rpm -q --queryformat '%{VERSION}' rocm-core` so ROCm version detection
also works on RHEL/openEuler-style images
(e.g. rocm-core-7.2.0.70200-43.el8.x86_64 -> 7.2.0.70200 -> 7.2).

Applied to both install_triton.sh and download_triton_wheel.sh.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mengfei-jiang mengfei-jiang requested a review from a team June 17, 2026 08:07
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 3775 --add-label <label>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants