Simplify ck_gemm_a8w8_blockscale GemmSpecialization construction#3813
Open
jbelloncastro wants to merge 1 commit into
Open
Simplify ck_gemm_a8w8_blockscale GemmSpecialization construction#3813jbelloncastro wants to merge 1 commit into
jbelloncastro wants to merge 1 commit into
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simplifies the logic behind constructing an enum value for GemmSpecialization.
Technical Details
The global variable unordered_map is constructed during library initialization and performs memory allocations that are not really necessary to find the right configuration from the dimension and block size parameters.
The change reassigns the enum values such that they can be treated as a mask. The padding conditions simply add a new bit to the mask if necessary.
The value reassignment will make chains of conditionals conditionals slightly more complicated, but not as much as the previous cost of enum construction.
Test Plan
Test Result
Submission Checklist