Apply OvO patch to fix line wrapping in compiler timing output#2223
Open
bhandarkar-pranav wants to merge 1 commit into
Open
Apply OvO patch to fix line wrapping in compiler timing output#2223bhandarkar-pranav wants to merge 1 commit into
bhandarkar-pranav wants to merge 1 commit into
Conversation
This change implements automatic patching for the OvO test suite to prevent line wrapping in compiler timing output logs. Changes: - Add bin/patches/ovo.patch: Sets COLUMNS=1000 to prevent line wrapping - Update bin/patches/patch-control-file_23.0.txt: Add OvO patch entry - Modify bin/run_ovo.sh: Apply patch before test execution and remove after completion The patch sets a wide terminal width (COLUMNS=1000) both as an environment variable and explicitly in make commands to ensure compiler timing output is not wrapped, making logs more readable. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
bhandarkar-pranav
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
dpalermo
approved these changes
May 14, 2026
Contributor
dpalermo
left a comment
dpalermo
left a comment
There was a problem hiding this comment.
LGTM, but I think this should already be covered by your aomp-config-ctime.env patch that set COLUMNS=1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change implements automatic patching for the OvO test suite to prevent line wrapping in compiler timing output logs.
Technical Details
The patch sets a wide terminal width (COLUMNS=1000) both as an environment variable and explicitly in make commands to ensure compiler timing output is not wrapped, making logs more readable. More importantly, this allows
--time-passesdata to be properly analyzed by LLVMOptTimeVisualizer.py. For instance, this is what was happeningLine Wrapping Example
The -time-passes output format is:
With PTY COLUMNS=80, that long line gets wrapped mid-timing-value:
What appeared in the log:
The 4th timing value 0.0000 ( 0.0%) got split at column 80:
Result: The parser sees 0.00 on one line (invalid) and 00 ( 0.0%) on the next (also invalid).
Changes: