chore: consolidate all optional deps into default dependencies#146
Merged
Conversation
Move dev, kubernetes, and all optional dependency groups into the main dependencies list and remove [project.optional-dependencies]. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
coketaste
requested review from
Cemberk,
Rohan138,
gargrahul and
leconcio
as code owners
There was a problem hiding this comment.
Pull request overview
This PR consolidates previously optional dependency groups (dev tooling, pytest plugins, Kubernetes support) into the package’s default install requirements to make pip install madengine include everything by default and remove the need for extras.
Changes:
- Moved Kubernetes and development/test tool dependencies from
[project.optional-dependencies]into[project].dependencies. - Removed the
dev,kubernetes, andallextras groups frompyproject.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Follow-up to the optional-deps consolidation: remove now-invalid madengine[dev]/[all]/[kubernetes] install commands from docs and runtime messages, and pin pytest>=7.0 to match minversion. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
|
|
||
| ### Changed | ||
|
|
||
| - **All dependencies are now included by default**: Kubernetes support (`kubernetes>=28.0.0`) and development tools (`pytest>=7.0`, `black`, `mypy`, `isort`, `pre-commit`, etc.) are bundled into the base `dependencies` list. The `[kubernetes]`, `[dev]`, and `[all]` extras have been removed — a plain `pip install madengine` or `pip install -e .` installs everything. All documentation and in-package install guidance has been updated accordingly. |
mkuznet1
added a commit
to mkuznet1/madengine
that referenced
this pull request
Jun 15, 2026
Merges 4 upstream commits (ef87d05..3a68be8) into the multi-node SLURM branch: - feat: canonicalize launcher aliases; extract MAD_MULTI_NODE_RUNNER resolver into _resolve_local_multi_node_runner_env() (upstream ROCm#132) - fix(run): --skip-model-run now starts container before skipping model script (ROCm#145) - chore: consolidate optional deps into default dependencies (ROCm#146) - Guyen/develop build-context folder change 2 (ROCm#144) Conflict in src/madengine/execution/container_runner.py resolved: - Upstream's if/else skip_model_run wrapper is the outer structure - Our try/except RuntimeError (container diagnostics on failure) is placed inside the else: branch around model_docker.sh() - Our elif skip_perf_collection: status branch and fallback or-clause are preserved in the else: branch status logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Optional dependency groups added friction — contributors had to know to run pip install -e ".[dev]" or pip install -e ".[all]" to get a working dev environment. Consolidating into
defaults eliminates that bootstrapping ambiguity.
Test plan