Skip to content

[utest][pwm] Add configurable PWM matrix test - #11754

Open
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:fix/pwm-utest-matrix
Open

[utest][pwm] Add configurable PWM matrix test#11754
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:fix/pwm-utest-matrix

Conversation

@CYFS3

@CYFS3 CYFS3 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

现有 PWM utest 缺少可复用的多通道、分组和频率/占空比变化验证能力，难以覆盖固定输出与动态输出组合，也无法按通道独立控制是否参与测试。新增可配置的 PWM 矩阵测试，为不同 BSP 提供统一的 PWM 功能回归入口。

你的解决方案是什么 (what is your solution)

新增 PWM utest 及其 Kconfig/SCons 集成。测试按组顺序执行，同一组内启用的通道并发运行；每个通道可以独立选择设备名、通道号、是否启用、波形点表、更新间隔和读回容差，并在设置后可通过 PWM_CMD_GET 进行可选的周期/脉宽校验。

components/drivers/misc/utest/pwm_tc_config.h 是默认配置入口，主要配置方式如下：

  • PWM_TC_CFG_CHANNEL_<n>_ENABLED：选择通道是否启动。默认只启用通道 1，其他示例通道关闭。
  • PWM_TC_CFG_CHANNEL_<n>_DEVICE_NAME 和 PWM_TC_CFG_CHANNEL_<n>_NUMBER：配置 PWM 设备名和硬件通道号。
  • PWM_TC_CFG_CHANNEL_<n>_READBACK_TOLERANCE：配置读回周期/脉宽容差，单位为万分比；设置为 0 时关闭读回校验。
  • PWM_TC_POINT_PERCENT(frequency, duty)：用 Hz 和百分比定义频率/占空比点；也可用 PWM_TC_POINT 直接使用万分比占空比。
  • PWM_TC_MODE_FIXED：固定单个频率和占空比；PWM_TC_MODE_SWEEP_ONCE：按点表变化一次并保持最后一点；PWM_TC_MODE_SWEEP_LOOP：按点表循环变化。
  • PWM_TC_CHANNEL_CONFIG：为每个通道选择模式、点表和步进间隔；每个通道可以使用不同配置。
  • PWM_TC_CFG_GROUP_<n>_DURATION_MS 和 PWM_TC_GROUPS：配置每组运行时长和组执行顺序。新增通道时，在通道配置数组中增加对应条目，并确保 RT_PWM_TC_MAX_CHANNELS 足够。

Kconfig 还提供 RT_UTEST_PWM、RT_PWM_TC_CONFIG_FILE、RT_PWM_TC_MAX_CHANNELS 和 RT_PWM_TC_TIMEOUT，分别用于启用测试、替换配置头文件、限制单组并发通道数和设置测试超时。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/misc/SConscript
  • components/drivers/misc/utest/Kconfig
  • components/drivers/misc/utest/SConscript
  • components/drivers/misc/utest/pwm_tc.c
  • components/drivers/misc/utest/pwm_tc_config.h
  • components/utilities/utest/Kconfig

📊 Current Review Status (Last Updated: 2026-08-28 15:03 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支（通常为 master）
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix/pwm-utest-matrix
    Enter PR branch fix/pwm-utest-matrix in the branch field
  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后，提交将自动更新至 fix/pwm-utest-matrix 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/pwm-utest-matrix branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@CYFS3 CYFS3 mentioned this pull request Aug 26, 2026
Open
34 tasks
@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

k230

  • SRAM: .text +64 B (+0.0%, 1,123,067 B / 268,300,288 B, total: 0% used)

nuvoton-m487

  • CODE: .text +84 B (+0.0%, 356,016 B / 524,288 B, total: 68% used)

simulator

Rbb666
Rbb666 reviewed Aug 28, 2026
View reviewed changes
Comment thread components/drivers/misc/utest/pwm_tc.c
rt_size_t index;

pwm_tc_active_count = 0;
if (PWM_TC_GROUP_COUNT == 0)

@Rbb666 Rbb666 Aug 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pwm_tc_stop_active_channels() 在关闭失败时刻意保留 pwm_tc_active_count，但下次运行时 utest_tc_init() 直接将其清零。连续运行测试时，残留输出将永远无法再被 cleanup 跟踪和关闭。

Comment thread components/drivers/misc/utest/pwm_tc.c
"components.drivers.pwm.configuration_matrix",
utest_tc_init,
utest_tc_cleanup,
RT_PWM_TC_TIMEOUT);

@Rbb666 Rbb666 Aug 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RT_PWM_TC_TIMEOUT 实际不生效。它只被写入 UTEST_TC_EXPORT；当前 UTest 执行器仅显示 run_timeout，不会据此中止测试。因此将超时设为 1 秒时，默认 3 秒矩阵仍会完整运行，配置项与说明不符。

Comment thread components/drivers/misc/utest/pwm_tc.c Outdated
{
rt_tick_t tick;

tick = rt_tick_from_millisecond(millisecond);

@Rbb666 Rbb666 Aug 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

毫秒值由 rt_uint32_t 隐式传给接受 rt_int32_t 的 rt_tick_from_millisecond()。大于 INT32_MAX 的组时长或步进间隔会被解释成负值并转换成 RT_WAITING_FOREVER，可能让输出长期保持开启。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component: drivers/misc component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CYFS3 @Rbb666