Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context options interpolated into HTML bodies were rendered verbatim, so values like
<script>alert('xss')</script>could land in the email. This typically is no issue: developer authors templates and most (all?) email clients strip<script>tags (but attributes like onerror and layout-breaking tags can still slip through).So mitigate this altogether and only explicitly allow HTML with
h()andhtml_safe(). Context options are now auto-escaped when rendered as HTML; useh(value)/html_safe(value)per attribute orhtml_safe { … }per block to opt out. Subject and plain-text bodies are unaffected.This is a breaking change: HTML emails relying on raw interpolation must now wrap values in
h(value)/html_safe(value).