Skip to content

Record Jev evidence and document its public contract - #94

Merged
cirsteve merged 4 commits into
epic/jev-supportfrom
cohort/0df295da-323e-4d31-8308-704ce0f9bbcf/jev-evidence-and-surface
Sep 26, 2026
Merged

cirsteve merged 4 commits into
epic/jev-supportfrom
cohort/0df295da-323e-4d31-8308-704ce0f9bbcf/jev-evidence-and-surface

Conversation

@gated-review

@gated-review gated-review Bot commented Sep 26, 2026

Copy link
Copy Markdown

Summary

  • Vendor a post-text-free excerpt of the recorded Assay response with provenance and a reconstructed request, then assert a full typed round trip.
  • Lock jig.jev exports and document the client, wire contract, trace recipe, and optional credentialed smoke check.

Verification

  • Full suite: 1,230 passed, 1 existing aiosqlite thread warning (repository virtual environment, local socket access).
  • Fixture key scan and git diff --check passed.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8819709d-3dc5-4413-b0de-9bb41a1e0797

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Credential wiring, public-export compatibility, and redaction coverage issues remain unresolved.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds recorded Jev evidence, typed round-trip coverage, a defined public API, and documentation for usage and wire behavior.

Changes:

  • Adds sanitized request/response fixtures and provenance.
  • Locks Jev exports and validates documentation examples.
  • Documents tracing, retries, validation, and optional smoke testing.
File Summary
tests/​test_public_api.py Enforces Jev export boundaries.
tests/​test_jev_recorded_roundtrip.py Validates recorded typed round trips and redaction fields; redaction coverage is incomplete.
tests/​test_jev_public_api.py Locks the documented Jev API surface.
tests/​test_docs_snippets.py Executes documentation examples.
tests/​fixtures/​jev/​recorded-run/​response.json Stores redacted response evidence.
tests/​fixtures/​jev/​recorded-run/​request.json Stores reconstructed request evidence.
tests/​fixtures/​jev/​recorded-run/​provenance.json Records fixture provenance.
src/​jig/​jev/​__init__.py Defines Jev exports; compatibility of removed exports requires resolution.
scripts/​jev_smoke.py Provides an optional smoke check; credential wiring requires correction.
README.md Links Jev documentation and smoke usage.
docs/​jev.md Documents client usage and tracing.
docs/​jev-contract.md Documents wire and retry contracts.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/jev_smoke.py
@cirsteve
cirsteve merged commit b55165a into epic/jev-support Sep 26, 2026
2 checks passed
@cirsteve
cirsteve deleted the cohort/0df295da-323e-4d31-8308-704ce0f9bbcf/jev-evidence-and-surface branch September 26, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants