fix: Fix a bug that could cause unexpected block movement when inserting blocks from the toolbox - #10289
Merged
Merged
Conversation
…ing blocks from the toolbox
lizschwab
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10183
Proposed Changes
This PR fixes a bug that caused blocks on the workspace to be bumped when inserting a new block from the flyout via the keyboard. When the newly-inserted block was rendered, it called
bumpNeighbors(), which is normally suppressed when a drag is in progress. However, the workspace reported drag status based on the keyboard mover, and it reported its status based on having a draggable. The draggable wasn't actually set until afteronDragStart(), so at the point the block was rendered and tried to bump neighbours it appeared that a drag was not in progress, thus allowing the bump to proceed and scooch blocks that should have remained stationary out of the way. Now, theKeyboardMovertracks its dragging/moving state with an instance variable explicitly for that, rather than relying on the presence of a draggable, which resolves the timing issue.Reason for Changes
Blocks shouldn't move by themselves.