Skip to content

chore: Don't run reviewer assignment action for teams - #10294

Merged
gonfunko merged 1 commit into
mainfrom
reviewer-assignment
Aug 19, 2026
Merged

chore: Don't run reviewer assignment action for teams#10294
gonfunko merged 1 commit into
mainfrom
reviewer-assignment

Conversation

@gonfunko

Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #10284

Proposed Changes

This PR fixes flakes in the reviewer assignment GitHub action. The investigation was LLM-assisted; the flake was caused by this action being triggered twice as Liz noted in the issue, once for the Blockly team and once for the individual team member that Github's reviewer assignment selected. The two action invocations could trample each other, depending on timing. Now, the action is skipped when it gets invoked for the team assignment, and only runs for the individual assignment. It also awaits the API call so errors actually get caught, and grabs the individual to assign the PR to from the event rather than the PR object.

Reason for Changes

Flaky tooling is annoying.

@gonfunko
gonfunko requested a review from a team as a code owner August 19, 2026 18:27
@gonfunko
gonfunko requested a review from lizschwab August 19, 2026 18:27
@github-actions github-actions Bot added the PR: chore General chores (dependencies, typos, etc) label Aug 19, 2026
@gonfunko
gonfunko merged commit 946ca88 into main Aug 19, 2026
10 of 11 checks passed
@gonfunko
gonfunko deleted the reviewer-assignment branch August 19, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: chore General chores (dependencies, typos, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assign requested reviewers action is flaky

2 participants