fix: Do not re-announce moves that stay on the same connection target - #10308
Merged
Conversation
lizschwab
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Adds an early return before announcing move mode updates if the target connection has not changed.
Reason for Changes
Prevents repeated/stuttering announcements like "M-M-M-M-Moving on workspace."
This check is based on the actual connections themselves rather than a simple announcement string comparison. This is necessary so that moves to distinct connections with the same labels (e.g. empty
else ifs) are still announced.Test Coverage
One new test checks that the live region is not updated between several on-workspace drags.
The other new ensures that identical move announcements can still happen when expected.
I manually tested these changes using VoiceOver with speech unmuted.