Skip to content

fix(store): surface FlushFileBuffers failure in journal SYNC mode #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singaraiona merged 1 commit into from
Jul 18, 2026
Merged

fix(store): surface FlushFileBuffers failure in journal SYNC mode #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/store/journal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@ ray_err_t ray_journal_write_bytes(const ray_ipc_header_t* hdr,
#ifndef RAY_OS_WINDOWS
if (fsync(fileno(g_journal.fp)) != 0) return RAY_ERR_IO;
#else
FlushFileBuffers((HANDLE)_get_osfhandle(_fileno(g_journal.fp)));
/* FlushFileBuffers returns 0 (FALSE) on failure — surface it as an I/O
* error like the fsync path above, so SYNC mode's durability guarantee
* isn't silently dropped on Windows. */
if (!FlushFileBuffers((HANDLE)_get_osfhandle(_fileno(g_journal.fp))))
return RAY_ERR_IO;
#endif
}
return RAY_OK;
Expand Down
Loading