Skip to content

Dockerfile: drop redundant install_pyrdl.sh step#885

Merged
calvinp0 merged 1 commit into
mainfrom
docker_rdl
May 9, 2026
Merged

Dockerfile: drop redundant install_pyrdl.sh step#885
calvinp0 merged 1 commit into
mainfrom
docker_rdl

Conversation

@calvinp0
Copy link
Copy Markdown
Member

@calvinp0 calvinp0 commented May 7, 2026

Summary

  • py-rdl is now resolved via environment.yml (danagroup::py-rdl), so the explicit bash ./devtools/install_pyrdl.sh invocation during the arc_env build stage is redundant.
  • Removes the chained call from line 63 of the Dockerfile while preserving make compile and the bash -euxo pipefail safety wrapper.

Test plan

  • Docker image builds successfully (docker build .)
  • arc_env contains a working py_rdl import after build

Copilot AI review requested due to automatic review settings May 7, 2026 18:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the Docker build-stage invocation of devtools/install_pyrdl.sh, relying on environment.yml (via danagroup::py-rdl) to provide py-rdl in arc_env.

Changes:

  • Drop the chained bash ./devtools/install_pyrdl.sh from the arc_env build stage.
  • Preserve the bash -euxo pipefail wrapper and keep make compile as the build step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.43%. Comparing base (b521d1e) to head (5869abc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   60.51%   60.43%   -0.08%     
==========================================
  Files         103      103              
  Lines       31165    31165              
  Branches     8126     8126              
==========================================
- Hits        18859    18835      -24     
- Misses       9947     9968      +21     
- Partials     2359     2362       +3     
Flag Coverage Δ
functionaltests 60.43% <ø> (-0.08%) ⬇️
unittests 60.43% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@calvinp0 calvinp0 requested review from Lilachn91 and alongd May 8, 2026 13:36
py-rdl is now installed via environment.yml (danagroup::py-rdl), so
running devtools/install_pyrdl.sh during the arc_env build is redundant.
@calvinp0 calvinp0 merged commit b71e1ab into main May 9, 2026
8 of 9 checks passed
@calvinp0 calvinp0 deleted the docker_rdl branch May 9, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants