Dockerfile: drop redundant install_pyrdl.sh step#885
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the Docker build-stage invocation of devtools/install_pyrdl.sh, relying on environment.yml (via danagroup::py-rdl) to provide py-rdl in arc_env.
Changes:
- Drop the chained
bash ./devtools/install_pyrdl.shfrom thearc_envbuild stage. - Preserve the
bash -euxo pipefailwrapper and keepmake compileas the build step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
==========================================
- Coverage 60.51% 60.43% -0.08%
==========================================
Files 103 103
Lines 31165 31165
Branches 8126 8126
==========================================
- Hits 18859 18835 -24
- Misses 9947 9968 +21
- Partials 2359 2362 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alongd
approved these changes
May 9, 2026
py-rdl is now installed via environment.yml (danagroup::py-rdl), so running devtools/install_pyrdl.sh during the arc_env build is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py-rdlis now resolved viaenvironment.yml(danagroup::py-rdl), so the explicitbash ./devtools/install_pyrdl.shinvocation during the arc_env build stage is redundant.make compileand thebash -euxo pipefailsafety wrapper.Test plan
docker build .)arc_envcontains a workingpy_rdlimport after build