Halve Red Hat Mono underline thickness (#67) - #79
Open
srijavuppala wants to merge 1 commit into
Open
Conversation
Red Hat Mono set post.underlineThickness to 100 (10% of the 1000 UPM), twice the font's own OS/2.yStrikeoutSize (50) and about double a typical monospace value (e.g. Source Code Pro ~50). Pango draws spellcheck error underlines at 3x the underline thickness, so in gtksourceview the dotted error underline renders much larger than comparable fonts (RedHatOfficial#67). Set underlineThickness to 50 across all masters of RedHatMono.glyphs and RedHatMono-Italic.glyphs. This matches the existing strikeout weight and roughly halves the rendered error-underline size. Verified with a fontmake rebuild: post.underlineThickness is 50 for all Mono styles (roman + italic) and all glyph outlines are byte-identical to the previous build. underlinePosition is left unchanged. Fonts binaries should be regenerated from these sources on the next release build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #67 — the dotted spellcheck error underline in gtksourceview renders much larger with Red Hat Mono than with comparable fonts.
Cause: Red Hat Mono sets
post.underlineThicknessto 100 (10% of the 1000 UPM) — twice the font's ownOS/2.yStrikeoutSize(50), and about double a typical monospace value (Source Code Pro, which @chergert notes "looks fine," uses ~50). Pango draws error underlines at 3× the underline thickness (pango_renderer_draw_error_underline), so the dots come out oversized.Fix: set
underlineThicknessto 50 across all masters ofRedHatMono.glyphsandRedHatMono-Italic.glyphs— matching the existing strikeout weight and roughly halving the rendered error-underline size.underlinePositionis left unchanged.Verification
Rebuilt Mono (roman + italic) with fontmake:
post.underlineThicknessis now 50 for all styles.postmetric changes).Scoped to Red Hat Mono, the font in the report. Red Hat Text and Display carry the same value if the maintainers would like it applied there too. The exact target is of course a design call — 50 matches the strikeout weight and Source Code Pro, but feel free to tune it. Binaries should be regenerated from these sources on the next release build.