Remove deprecated wait() method from DataVolume class#2704
Draft
ema-aka-young wants to merge 2 commits intoRedHatQE:mainfrom
Draft
Remove deprecated wait() method from DataVolume class#2704ema-aka-young wants to merge 2 commits intoRedHatQE:mainfrom
ema-aka-young wants to merge 2 commits intoRedHatQE:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
The intention is to allow
DataVolume.wait()to fall back to the parentResource.wait()method.More details:
What this PR does / why we need it:
Deprecate DataVolume.wait() in favor of wait_for_dv_success() to fix bad practice and prevent bugs.
Which issue(s) this PR fixes:
This PR will allow us to safely de-quarantine https://github.com/RedHatQE/openshift-virtualization-tests/blob/2ee0d6e604bc3ade241bfb1a53879875eb7d2ecc/tests/storage/cdi_import/test_import_http.py#L62
Special notes for reviewer:
This PR needs to be merged first
This PR is part of this task, and continues the work started in #2613
Bug:
Summary by CodeRabbit