Skip to content

Remove deprecated wait() method from DataVolume class#2704

Draft
ema-aka-young wants to merge 2 commits intoRedHatQE:mainfrom
ema-aka-young:cnv-73197-remove-dv-wait
Draft

Remove deprecated wait() method from DataVolume class#2704
ema-aka-young wants to merge 2 commits intoRedHatQE:mainfrom
ema-aka-young:cnv-73197-remove-dv-wait

Conversation

@ema-aka-young
Copy link
Copy Markdown
Contributor

@ema-aka-young ema-aka-young commented Apr 30, 2026

Short description:

The intention is to allow DataVolume.wait() to fall back to the parent Resource.wait() method.

More details:
What this PR does / why we need it:

Deprecate DataVolume.wait() in favor of wait_for_dv_success() to fix bad practice and prevent bugs.

Which issue(s) this PR fixes:

This PR will allow us to safely de-quarantine https://github.com/RedHatQE/openshift-virtualization-tests/blob/2ee0d6e604bc3ade241bfb1a53879875eb7d2ecc/tests/storage/cdi_import/test_import_http.py#L62

Special notes for reviewer:

This PR needs to be merged first

This PR is part of this task, and continues the work started in #2613

Bug:

Summary by CodeRabbit

  • Chores
    • Removed deprecated DataVolume wait method and its associated logic. Applications relying on this functionality must transition to alternative approaches for resource synchronization and status monitoring to maintain proper workflow coordination.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49896bb6-ca52-4b06-a24f-32bb1e5947e7

📥 Commits

Reviewing files that changed from the base of the PR and between 3d05f36 and f48f223.

📒 Files selected for processing (1)
  • ocp_resources/datavolume.py
💤 Files with no reviewable changes (1)
  • ocp_resources/datavolume.py

Walkthrough

The DataVolume.wait() method is removed from the codebase. This method previously emitted a deprecation warning and controlled waiting behavior for DataVolume resource status and PVC binding states.

Changes

Cohort / File(s) Summary
Deprecated Method Removal
ocp_resources/datavolume.py
Removed deprecated DataVolume.wait() method that handled status checks and conditional waiting logic for SUCCEEDED state and PVC BOUND binding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removal of the deprecated wait() method from the DataVolume class, which is the primary modification in the changeset.
Description check ✅ Passed The description follows the template structure with all major sections completed, including short description, what the PR does, related issues, and notes for reviewers with relevant context and dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ema-aka-young ema-aka-young marked this pull request as ready for review April 30, 2026 08:10
@ema-aka-young ema-aka-young marked this pull request as draft April 30, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant