Skip to content

fix(docs-infra): remove colons from ISO27001 paths - #341

Open
Mondotrasho wants to merge 1 commit into
Redback-Operations:mainfrom
Mondotrasho:fix/windows-incompatible-iso27001-path
Open

fix(docs-infra): remove colons from ISO27001 paths#341
Mondotrasho wants to merge 1 commit into
Redback-Operations:mainfrom
Mondotrasho:fix/windows-incompatible-iso27001-path

Conversation

@Mondotrasho

@Mondotrasho Mondotrasho commented Jul 21, 2026

Copy link
Copy Markdown

Summary

Renames the ISO27001 folder and main Markdown file to remove colons from their paths.

Attempts to clone the repository on Windows using both the Git CLI and GitHub Desktop failed because these paths are not Windows compatible.

Changes

  • Renamed the affected folder and Markdown file.
  • Kept all document contents unchanged.

Context

The folder was introduced in #334 and the main file was renamed in #338.

Testing

  • Confirmed all 12 files are detected as 100% renames.
  • Confirmed there are no unrelated changes.
  • Ran npm run build successfully.

@Mondotrasho
Mondotrasho requested review from a team as code owners July 21, 2026 02:33
@Mondotrasho

Mondotrasho commented Jul 22, 2026

Copy link
Copy Markdown
Author

This change was identified while setting up the company documentation repository for SmartBike VR documentation work and is now tracked in the Redback SmartBikeVR Planner.

The PR comes from a dedicated branch in my fork. Please let me know if there are any additional documentation-repository contribution requirements I should follow.

@Mondotrasho Mondotrasho changed the title Fix Windows-incompatible ISO27001 paths fix(docs-infra): remove colons from ISO27001 paths Jul 27, 2026
@Mondotrasho

Copy link
Copy Markdown
Author

Hi @raymondchoy14, I found this issue while setting up the company documentation repository for my SmartBike VR documentation work.

The ISO27001 folder and Markdown filename introduced through #334 and #338 contain colons, which prevent the repository from being cloned or checked out on Windows. This PR contains rename-only changes, keeps all document contents unchanged and passes the documentation build.

The PR has been open since July 21 without a review. Could you please confirm whether this is the correct contribution workflow and either review it or direct me to the current maintainer of the documentation repository?

I only have access to the SmartBike VR Planner, and its tasks do not appear to use the numbered task format shown in the Git contribution guide, so I created a task in the SmartBike VR Planner but I am not sure how to get the task number specified in the git contribution guide. (https://verdant-raindrop-f3e404.netlify.app/processes/quality-assurance/git-contributions-guide/ from https://github.com/Capstone-Template-orginisation/website-template)

Thanks for your time.

@Mondotrasho

Copy link
Copy Markdown
Author

@Redback-Operations/tutors

Sorry for the at I am wondering if perhaps you are the group in charge of this repo for this trimester?

I have had very little luck tracking down who is in charge of overall documentation and would both appreciate eyes on this PR as well as direction on who I should contact in future for general documentation queries and the redback-documentation repo as a whole.

@Arun225295196 Arun225295196 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your scan workflow is triggered by pull_request_target (visible from the error), which runs with access to your base repo's secrets and GITHUB_TOKEN — even for PRs coming from forks. GitHub refuses to let actions/checkout pull the fork's code into that trusted context by default, because a malicious fork PR could otherwise steal your secrets or push malicious code that runs with write access. This is the classic "pwn request" vulnerability class.

@Mondotrasho

Copy link
Copy Markdown
Author

Thanks, I have split the OWASP workflow fix into a separate PR rather than adding it to this one.

It changes the scanner from pull_request_target to pull_request and skips the PR comment when running from a fork, while still allowing the scan itself to pass/fail normally.

PR: #342

The existing OWASP check on this PR may still fail until #342 is merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants