MOD-15262- update the GetUserUserName api according to redis#87
Open
TalBarYakar wants to merge 1 commit intomasterfrom
Open
MOD-15262- update the GetUserUserName api according to redis#87TalBarYakar wants to merge 1 commit intomasterfrom
TalBarYakar wants to merge 1 commit intomasterfrom
Conversation
galcohen-redislabs
approved these changes
Apr 29, 2026
gabsow
approved these changes
Apr 29, 2026
galcohen-redislabs
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the public module API signature for
RedisModule_GetUserUsername, which is a compile-time breaking change for any modules calling it. Risk is limited to API compatibility/build failures rather than runtime behavior.Overview
Updates the Redis Modules header to match upstream Redis by changing
RedisModule_GetUserUsernameto take aRedisModuleCtx *ctxparameter in addition to theRedisModuleUser *userargument.This is an API signature change that requires updating any module code that calls
RedisModule_GetUserUsernameto pass a context.Reviewed by Cursor Bugbot for commit f4a9e90. Bugbot is set up for automated code reviews on this repo. Configure here.