Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
The sampler now lifts the selected
oneOfalternative'srequiredonto the parent soskipNonRequiredcan see it, and omits properties that are required only by sibling alternatives so the example matches exactly one subschema:{ "a": "string" }. It still selects the firstoneOf.oneOfalternatives that only setrequiredwere ignored when building the parent object sample. For{ "type": "object", "properties": { "a": { "type": "string" }, "b": { "type": "string" } }, "oneOf": [ { "required": ["a"] }, { "required": ["b"] } ] }the sampler emitted
{ "a": "string", "b": "string" }, which matches both alternatives (must match exactly one schema in oneOf).{ skipNonRequired: true }produced{}, which matches none.Other optional parent properties stay, matching the default "sample all properties" behaviour. The invalid sample was exclusivity (
aandbtogether match two branches), not extra optional fields.Emitting only the selected required keys (implied
skipNonRequiredunderoneOf) would also drop unrelated optional properties such asc. Happy to switch to selected required keys only if you prefer smaller examples.requiredis read from the alternative object itself (the reporter's schema).$ref/ nestedallOfon aoneOfitem is unchanged.Closes #151.
Reference
#151
Testing
{ a: "string" }skipNonRequired: trueis{ a: "string" }, not{}oneOf/anyOf/ discriminator tests still passScreenshots (optional)
N/A
Check yourself
Security