fix: correct stale Arbitrum Sepolia addresses to match deployment JSONs#2
Merged
Merged
Conversation
The package READMEs and the offchain operator constants carried contract addresses from an older deployment. Update them to the current deployment in packages/*/deployments/arbitrumSepolia.json (matching the SDK addresses.ts). These stale READMEs were the source of the wrong addresses on the docs site. READMEs: escrow, orchestration, offchain, operator-cli, operator. Operator runtime config/constants: - shared/src/constants.ts (CONTRACTS.ARBITRUM_SEPOLIA) - operator-cli/src/utils/cctp.ts (arbitrumSepoliaContracts escrow/receiver) - operator-cli/.env.example and operator/.env.example (incl. ConfidentialUSDC) Addresses corrected: OperatorRegistry, TaskExecutor, FeeManager, CCTPHandler, ConfidentialEscrow, CCTPV2ConfidentialEscrowReceiver, ConfidentialUSDC. CCTP infra addresses (USDC, TokenMessenger, MessageTransmitter) were already correct and are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
grimnote
requested review from
0xkkkn,
VladVelik,
jishumi,
madschristensen99 and
vergil-dv
as code owners
…arking in READMEs - Removed fabricated protocol-fee claims (Protocol Fee 0.3% / PROTOCOL_FEE_BPS=30 / "Protocol Fee BPS"). FeeManager has no protocol fee — only operatorFeeBps, paid to the operator. - Marked the residual operator fee (operatorFeeBps=50) as "to be removed" — no fees are charged today, protocol or operator. - Marked mock tokens: MockGovernanceToken (GOV, mock), Confidential token (mock / interim). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The package READMEs and the offchain operator runtime constants carried contract addresses from an older deployment. This corrects them to the current deployment in
packages/*/deployments/arbitrumSepolia.json(which matches the SDKaddresses.ts). These stale READMEs were the source of the wrong addresses that showed up on the docs site.What changed
READMEs (documentation):
escrow,orchestration,offchain,operator-cli,operator.Operator runtime config/constants (functional — the operator was pointing at old contracts):
offchain/packages/shared/src/constants.ts—CONTRACTS.ARBITRUM_SEPOLIAoffchain/packages/operator-cli/src/utils/cctp.ts—arbitrumSepoliaContracts.{escrow,escrowReceiver}offchain/packages/operator-cli/.env.exampleandoffchain/packages/operator/.env.example(incl. theCONFIDENTIAL_TOKEN_ADDRESS)Addresses corrected
0x1422…29590x5Ac3a3750e0a9f7d4ddBC0B52c3f13E8f927FB590x7F24…22620x4D239335f39E585Bb75631C4683538EFC496a5EB0x5a11…01560x639f5cB99DcF9681A0461A1452c3845811d3308A0xb37A…F2730x575186a64B9FC49E135A2440DC4A1395edc0F3aD0xbe1e…549A60xF50A9CF008a79CFCA39aa9a345aa06e8D12727E20x67AE…38d00xe0E6CC9Ee62Fa36b96eC4F50CDc462Fd14aa0fD30x6B6E…Ed89F0x42E47f9bA89712C317f60A72C81A610A2b68c48aCCTP infra addresses (USDC, TokenMessenger, MessageTransmitter) were already correct and are unchanged. All changes are string-constant/markdown only — no logic changes.
Notes / follow-ups (not in this PR)
offchain/README.mdshows a "Protocol Fee | 0.3%" line that contradicts the zero-protocol-fee posture — left for a separate copy fix.pnpm installnot run); changes are constant-only, but a maintainer should runpnpm --filter ./packages/** typecheckbefore merge to be safe.🤖 Generated with Claude Code