fix(backend): make transfer lifecycle transitions concurrency-safe - #145
Open
woahwhattheheck wants to merge 1 commit into
Open
woahwhattheheck wants to merge 1 commit into
woahwhattheheck wants to merge 1 commit into
Conversation
Add optimistic versioning, per-transfer lifecycle leases, and an idempotent settlement worker so concurrent claim/cancel cannot produce impossible states or double settlement. Terminal mutations require If-Match plus Idempotency-Key and return explicit 409/428 conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #133.
Makes terminal transfer mutations (claim / cancel) concurrency-safe end-to-end: allowed transitions, optimistic version checks, one terminal outcome, idempotent provider settlement, and safe conflict responses. Strictly stronger than a version-only check by adding a per-transfer lifecycle lease so two different operation keys cannot both prepare provider work for the same transfer.
What changed
version(starts at 1); create / get / archive / unarchive / claim / cancel responses expose it as a strongETag.If-Match(428 if missing) plusIdempotency-Key; stale versions and illegal transitions return 409 with expected/actual version and current status.compareAndSetTransition) for terminal status changes.settlementWorkersettles claims under a stable operation id; receipts live in the shared store so a worker-module reload still returns the first artifact.Design tradeoffs
If-Match+Idempotency-Key— intentional optimistic-concurrency contract.(id, version)and share leases/receipts across workers.Acceptance criteria mapping
compareAndSetTransitionsettleCalls === 1)Test evidence
Focused suites:
test/transferLifecycleConcurrency.test.js,test/transferLifecycleHttp.test.js. Existing suite updated only where claim/cancel HTTP calls needed the new headers (test/requireScope.test.js); no unrelated tests skipped or weakened.Out of scope