feat(frontend): prevent duplicate transfer submissions across retries and navigation - #295
Open
woahwhattheheck wants to merge 5 commits into
Open
woahwhattheheck wants to merge 5 commits into
woahwhattheheck wants to merge 5 commits into
Conversation
Bind an idempotency key to the exact transfer payload, persist only a safe operation reference in sessionStorage, and return the prior transfer on repeated submits with the same key. Refresh restores in-flight status; an edited payload mintes a new intent. Closes RemitFlow#277
Prevent duplicate transfer submissions across double-clicks, retries, refresh, and navigation by persisting a safe operation reference and reconciling in-flight intents without auto-resubmitting.
Prevent duplicate transfer submissions across double-clicks, retries, timeouts, refresh, and navigation by fingerprinting the exact payload, persisting only a safe operation reference, and reconciling in-flight intents without auto-resubmitting. Changed payloads mint a new intent. Closes RemitFlow#277
Canonicalize amounts without collisions, retain an opaque session fingerprint, and give each acknowledged transfer a fresh key. Reject reused keys with a conflicting payload and recover accepted transfers without a saved ID. Closes RemitFlow#277
Copy initial records before appending so a cleared storage session starts clean.
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277
Summary
One user intent creates at most one transfer. A canonical payload fingerprint is bound to an idempotency key; only a safe operation reference is persisted across navigation/refresh; an edited payload requires a new intent.
Design
fingerprintTransferPayload/idempotencyKeyFor(src/utils/transferIntent.js) derive a stable key from the exact transferable fields (recipient, currencies, amounts, fee, rate).sessionStorage: key, fingerprint, transfer id, and operation status (submitting|unknown|succeeded|failed|dismissed). No secrets or raw form state.createTransferreturns the prior record for the same idempotency key, including concurrent in-flight replays (timeout / double-submit race).unknownso a retry reuses the same key.Tradeoffs
idempotencyKey(optional) preserves legacy records.Compatibility
sessionStorage.clear()inbeforeEachso intent refs cannot leak across suites.Test evidence
Coverage includes double-confirm, refresh restore, timeout key reuse, navigation reconcile, and changed-payload new key. Pre-existing failures on
main(e.g. quote decimal formatting assertions) are untouched.Out of scope