Skip to content

RG-T133 iOS Perms Fix - #56

Merged
ucswift merged 1 commit into
masterfrom
develop
Aug 27, 2026
Merged

RG-T133 iOS Perms Fix#56
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

Updates iOS permission declarations to use more explicit, App Store–compliant purpose strings and removes an unnecessary Face ID permission.

What changed

  • Replaced generic iOS permission descriptions with detailed user-facing explanations and concrete examples for:
    • Bluetooth access
    • Location while in use
    • Photo library access
    • Camera access
    • Microphone access
  • Added explicit configuration for the image picker permission prompts so photo and camera usage messages are clearly defined.
  • Added explicit camera permission text for the WebRTC plugin to prevent it from supplying a generic default permission message.
  • Updated secure storage configuration to disable Face ID permission text generation, since biometric-gated secure storage is not used.

Functional impact

  • iOS users will see clearer permission prompts that explain exactly how Resgrid IC uses Bluetooth, location, photos, camera, and microphone.
  • Prevents vague auto-generated permission messages from being included in the app.
  • Avoids requesting or declaring Face ID usage when that capability is not used.

Summary by CodeRabbit

  • Permissions
    • Updated iOS permission explanations with clearer details for Bluetooth, location, photo library, camera, and microphone access.
    • Added explicit camera and photo access settings for image selection and video calls.
    • Removed unnecessary Face ID permission messaging.

@Resgrid-Bot

Resgrid-Bot commented Aug 27, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a91092a6-e12c-4c98-9bc6-73af4fa78228

📥 Commits

Reviewing files that changed from the base of the PR and between 1df1a72 and 87fdbe0.

📒 Files selected for processing (1)
  • app.config.ts

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The iOS app configuration now defines detailed purpose strings for Bluetooth, location, photo library, camera, and microphone access. Expo plugin settings also disable Secure Store Face ID text and configure image picker and WebRTC camera permissions.

Changes

iOS Permission Configuration

Layer / File(s) Summary
Permission purpose strings
app.config.ts
Bluetooth, location, and microphone messages now describe Push-to-Talk, mapping, calls, chats, voice communication, and incident-scene use cases.
Plugin permission settings
app.config.ts
expo-secure-store disables Face ID permission text. expo-image-picker and WebRTC define explicit photo-library and camera permission messages.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 87fdb

This PR clarifies iOS permission prompts and removes an unused Face ID declaration; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing iOS permission configuration. It is concise and includes the tracking identifier RG-T133.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands.

@ucswift
ucswift merged commit c051aa5 into master Aug 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants