fix(pqi): don't restart an already-running peer streamer thread#327
Open
jolavillette wants to merge 1 commit into
Open
fix(pqi): don't restart an already-running peer streamer thread#327jolavillette wants to merge 1 commit into
jolavillette wants to merge 1 commit into
Conversation
pqiperson::handleNotifyEvent_locked() unconditionally calls activepqi->start() on CONNECT_SUCCESS. When a peer reconnects over the same interface, the streamer thread (pqithreadstreamer, an RsThread) is still running, so RsThread::start() hits its "already running" guard and logs `attempt to start already running thread: pqi <peer>` followed by a full stack trace, on every such reconnection. This is purely noise: start() was already failing (returning false), so the thread was never actually restarted; pqissl switches the socket over underneath the running streamer. Guard the call with RsThread::isRunning() so it is only (re)started when actually stopped. Behaviour is unchanged; only the spurious error + stack trace are gone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(pqi): don't restart an already-running peer streamer thread
pqiperson::handleNotifyEvent_locked() unconditionally calls activepqi->start() on CONNECT_SUCCESS. When a peer reconnects over the same interface, the streamer thread (pqithreadstreamer, an RsThread) is still running, so RsThread::start() hits its "already running" guard and logs
attempt to start already running thread: pqi <peer>followed by a full stack trace, on every such reconnection.This is purely noise: start() was already failing (returning false), so the thread was never actually restarted; pqissl switches the socket over underneath the running streamer. Guard the call with RsThread::isRunning() so it is only (re)started when actually stopped. Behaviour is unchanged; only the spurious error + stack trace are gone.