Skip to content

Add regression coverage for UpgradeStatus failure handling - #1230

Merged
thlpkee20-wq merged 1 commit into
RevoraOrg:masterfrom
attyolu:upgradeStatus
Sep 29, 2026
Merged

thlpkee20-wq merged 1 commit into
RevoraOrg:masterfrom
attyolu:upgradeStatus

Conversation

@attyolu

@attyolu attyolu commented Sep 29, 2026

Copy link
Copy Markdown

##closes #1087

Summary

  • Add regression coverage for UpgradeStatus handling in ContractUpgradeOrchestratorService.
  • Verify RPC rejection statuses are persisted as failed upgrades and exposed through the existing 503 error contract.
  • Cover successful PENDING submission and boundaries for unapproved upgrades and missing dry-run results.

Validation

  • Focused orchestrator test file: 40 tests passed.
  • TypeScript diagnostics for the changed service and test files: none.
  • Full test suite: not completed; the run was cancelled.
  • Repository-wide lint/build checks reported unrelated existing failures. Targeted lint reported only pre-existing any usages elsewhere in the test file.

@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@attyolu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@thlpkee20-wq
thlpkee20-wq merged commit 7fbf682 into RevoraOrg:master Sep 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add regression coverage for UpgradeStatus failure handling

2 participants