test: add dedicated test suite for latency-budgets - #1235
Merged
thlpkee20-wq merged 1 commit intoSep 29, 2026
Merged
thlpkee20-wq merged 1 commit into
thlpkee20-wq merged 1 commit into
Conversation
- Add src/lib/latency-budgets.test.ts with 40 focused tests covering
LatencyBudgetConfig shape, HOT_ROUTE_BUDGETS catalogue, getLatencyBudget()
(exact match, case-insensitive method, path normalisation, boundary inputs),
getAllBudgetedRoutes() defensive copy, state mutation safety, and
deterministic boundary behaviour
- Fix getLatencyBudget to return a shallow copy ({ ...found }) instead of
a direct reference into the internal catalogue array
- Fix getAllBudgetedRoutes to return element-level copies
(HOT_ROUTE_BUDGETS.map((b) => ({ ...b }))) so callers cannot corrupt
the canonical budget registry through mutation
All 40 tests pass. Zero lint and type errors in changed files.
|
@Promzy204-bad Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add src/lib/latency-budgets.test.ts with 40 focused tests covering LatencyBudgetConfig shape, HOT_ROUTE_BUDGETS catalogue, getLatencyBudget() (exact match, case-insensitive method, path normalisation, boundary inputs), getAllBudgetedRoutes() defensive copy, state mutation safety, and deterministic boundary behaviour
Fix getLatencyBudget to return a shallow copy ({ ...found }) instead of a direct reference into the internal catalogue array
Fix getAllBudgetedRoutes to return element-level copies (HOT_ROUTE_BUDGETS.map((b) => ({ ...b }))) so callers cannot corrupt the canonical budget registry through mutation
All 40 tests pass. Zero lint and type errors in changed files.
closes #1039