Conversation
Add focused regression coverage for requestIdMiddleware's empty-result path and adjacent behavior. Exercised cases: - missing, empty, and whitespace-only string headers - empty and blank-only header arrays - fallback to an existing request ID - trimming a normal header value - selecting the first non-empty array value - response header, request logger, and next() propagation Validation: - focused suite: 8 tests passed - surrounding request-ID suites: 9 tests passed - combined coverage gate: 17 tests passed with 95% thresholds - focused ESLint: passed - repository ESLint: blocked by 2,352 pre-existing findings - TypeScript build: blocked by pre-existing syntax/invalid-character errors in riskScoreEngine and health tests Security note: invalid or blank request ID headers cannot suppress trace ID generation or request-scoped logging. Refs RevoraOrg#1057
|
@taiwoMoil Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add focused regression coverage for requestIdMiddleware's empty-result path and adjacent behavior.
Exercised cases:
Validation:
Security note: invalid or blank request ID headers cannot suppress trace ID generation or request-scoped logging.
closes #1057