docs(runtime): scrub managed-boundary leaks from compass-runner records (RIG-3170) - #866
Open
rigel-mintaka wants to merge 3 commits into
Open
docs(runtime): scrub managed-boundary leaks from compass-runner records (RIG-3170)#866rigel-mintaka wants to merge 3 commits into
rigel-mintaka wants to merge 3 commits into
Conversation
…ds (RIG-3170) Apply the tightened public/private managed boundary (RIG-3153, merged #839; `docs/concepts/self-host-and-managed.md`) to five compass-runner-owned runtime design records: the public repo must not carry the managed product's end-state/rollout, and must never name or point at the private repo as a place. Content leaks (managed roadmap): - `microvm-runner.md`: reframe the managed deployment shape ("the managed service runs cloud-hypervisor on elastic, hourly, autoscaling bare-metal instances; AWS `*.metal` in standard ASGs; GCP `c3-*-metal`") to the core capability (cloud-hypervisor runs directly on a KVM-capable bare-metal host; no nesting tax). Drop the managed drop-sequencing pegged to the first-external-tenant milestone (two sites: constraint + abstract) — reframe to "off the critical path" / "once microVM is proven". - `compass-elastic-session-runtime/design.md`: drop the same first-external- tenant milestone peg from Decision 5 (I1 lands microVM "before it becomes the sole runtime"). Naming leaks (place-pointers to the private repo): - `design.md`: "Managed Compass (private monorepo, …)" and "all of which live in the private monorepo" -> "built out of tree" (dual-license fact kept). - `microvm-ci-dev-enablement.md`: "not the private monorepo's" and "the managed Compass will run from the private monorepo" -> "the managed service" / "built out of tree". - `managed-multitenancy/design.md`: "the private control-plane layer" and "its home is the private monorepo's AWS-EKS substrate design (RIG-2878)" -> "the out-of-tree managed control plane" (private-tracker slug dropped). - `microvm-v2a-guest-image-boot-spike.md`: reword the external-reference-gate rule statement to the tightened "never name or point at the private repo". Additive amendment to frozen records (no re-freeze); technical claims and code citations preserved, only the boundary-leaking prose reframed. Matches the merged scrub pattern from #838. Refs RIG-3170 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
…iew (RIG-3170) Review of #866 surfaced two blocking defects in the managed-boundary scrub, both fixed here as an additive commit: - Citation drift (high): the microvm-runner.md hunks were net -3 lines, shifting every downstream line and invalidating ~148 absolute `microvm-runner.md:N` citations across the corpus. Reflowed the two reframed passages to be per-hunk line-count-neutral so every citation resolves to its original text; every touched file is now line-neutral vs main (verified: microvm-runner 848, elastic design 905, microvm-ci-dev-enablement 503, microvm-v2a 669, managed-multitenancy 1099, microvm-kvm-only-amendment 117 — all match main). - Residual twin leak + falsified quote (high): microvm-kvm-only-amendment.md block-quotes design.md:892-894 and calls it "exactly as frozen"; the scrub edited that source line, so the quote both re-leaked the first-external-tenant milestone peg and misquoted its own source. Updated the block-quote to the post-scrub wording. - Falsified cross-reference + shape restatement (medium): compass-managed-multitenancy/design.md:441-446 attributed to D2 a "managed path frozen as elastic bare-metal (AWS *.metal, GCP c3-metal)" that the scrubbed D2 no longer contains, restating the exact deployment shape the scrub removed. Reframed to the post-scrub D2 claim (KVM-capable bare-metal, no managed-path attribution, no shape enum). - Ragged-reflow rejoin (low) in microvm-ci-dev-enablement.md and a parenthetical nit (low) in elastic design.md. Refs RIG-3170 Co-authored-by: Matt Wilkinson <matt@rigel.build>
…G-3170)
Round-2 review fold. The round-1 scrub rewrote D2's premise in
microvm-runner.md but left its concluding clause ", never the managed
path" — a banned positive claim about the managed product's deployment
shape, and a non-sequitur once its premise was scrubbed. Trim the clause
and rebalance the reflow; the D2 block stays line-count-neutral so the
compass-managed-multitenancy citation of :671-692 still resolves.
Also fix the citing record: managed-multitenancy/design.md now quotes D2
verbatim ("a self-inflicted, clearly-documented tradeoff", was missing
"clearly-documented") and rebalances a ragged fold artifact. All touched
lines line-count-neutral vs main.
Refs RIG-3170
Co-authored-by: Matt Wilkinson <matt@rigel.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the tightened public/private managed boundary (RIG-3153, merged #839;
docs/concepts/self-host-and-managed.md) to five compass-runner-owned runtimedesign records: the public repo must not carry the managed product's
end-state/rollout, and must never name or point at the private repo as a place.
Content leaks (managed roadmap):
microvm-runner.md: reframe the managed deployment shape ("the managedservice runs cloud-hypervisor on elastic, hourly, autoscaling bare-metal
instances; AWS
*.metalin standard ASGs; GCPc3-*-metal") to the corecapability (cloud-hypervisor runs directly on a KVM-capable bare-metal host;
no nesting tax). Drop the managed drop-sequencing pegged to the
first-external-tenant milestone (two sites: constraint + abstract) — reframe
to "off the critical path" / "once microVM is proven".
compass-elastic-session-runtime/design.md: drop the same first-external-tenant milestone peg from Decision 5 (I1 lands microVM "before it becomes the
sole runtime").
Naming leaks (place-pointers to the private repo):
design.md: "Managed Compass (private monorepo, …)" and "all of which livein the private monorepo" -> "built out of tree" (dual-license fact kept).
microvm-ci-dev-enablement.md: "not the private monorepo's" and "the managedCompass will run from the private monorepo" -> "the managed service" / "built
out of tree".
managed-multitenancy/design.md: "the private control-plane layer" and "itshome is the private monorepo's AWS-EKS substrate design (RIG-2878)" -> "the
out-of-tree managed control plane" (private-tracker slug dropped).
microvm-v2a-guest-image-boot-spike.md: reword the external-reference-gaterule statement to the tightened "never name or point at the private repo".
Additive amendment to frozen records (no re-freeze); technical claims and code
citations preserved, only the boundary-leaking prose reframed. Matches the
merged scrub pattern from #838.
Refs RIG-3170
Co-authored-by: Matt Wilkinson matt@rigel.build