fix(design): renumber colliding ledger ids DL-327..330 to DL-334..337 - #934
fix(design): renumber colliding ledger ids DL-327..330 to DL-334..337#934rigel-mintaka wants to merge 1 commit into
Conversation
`main` is red on `design-ledger-gate:check`: the delivery→EventFabric cutover record's ledger block (merged as #905) claimed DL-327..333, but four of those ids were already taken by records that merged first, so the ledger carries four duplicates and the gate fails on every branch rebased onto current `main`. Because the pre-push gate runs `moon ci`, this blocks every lane's submit — and a stale clone still reads green, so it is easy to miss. The four cutover rows move to the free tail; the earlier claimants keep their ids because already-merged records cite them and other lanes implement from those citations. | id | kept by | cutover row moved to | | --- | --- | --- | | DL-327 | SubjectService token principal (#868) | DL-334 (OQ-1 ack timing) | | DL-328 | gateway-credentials at-rest encryption (#859) | DL-335 (OQ-2 callback) | | DL-329 | compass-stack supervision | DL-336 (OQ-3 p1 DB role) | | DL-330 | apple-container macOS runner | DL-337 (OQ-3 p2 recovery) | DL-331/332/333 were already unique and keep their ids, so the cutover block is now contiguous at DL-331..337. Its record's `Ledger-impact` line and the four in-prose references are updated to match, including the DL-333 row's own citation of the reconnect trigger it rests on (DL-330 → DL-337). A `> Ledger note` above the Transport table records the mapping and its cause, matching the existing notes for DL-325 and DL-187..190. The note is the part that survives: #905's merged commit message and PR body still cite DL-327..330 for these rulings, and neither can be rewritten, so a reader arriving from that PR or a blame trail resolves the stale numbers through the note. No ruling text is altered — this is an identifier reconciliation. Verified: the ledger parses to 304 rows with zero duplicate ids (previously four), `design-ledger-gate` reports OK across 304 rows and 126 record headers, and markdownlint is clean. Ledger-impact: renumbers DL-327..330 to DL-334..337; no ruling changes. Refs RIG-3107 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-server-ledger-id-col.compass-eng-docs.pages.dev Deployed from Changed pages: |
|
Superseded by #927, which fixed the same DL-327..330 collision from the compass-managed lane and merged first, carrying its own annotate-don't-rewrite note in the cutover record. Only difference worth recording: #927 placed the ledger note in the cutover record while this PR placed it above the Transport table in |
1 participant
This PR is part of a stack containing 2 PRs:
mainmainis red ondesign-ledger-gate:check: the delivery→EventFabric cutoverrecord's ledger block (merged as #905) claimed DL-327..333, but four of those
ids were already taken by records that merged first, so the ledger carries four
duplicates and the gate fails on every branch rebased onto current
main.Because the pre-push gate runs
moon ci, this blocks every lane's submit — anda stale clone still reads green, so it is easy to miss.
The four cutover rows move to the free tail; the earlier claimants keep their
ids because already-merged records cite them and other lanes implement from
those citations.
DL-331/332/333 were already unique and keep their ids, so the cutover block is
now contiguous at DL-331..337. Its record's
Ledger-impactline and the fourin-prose references are updated to match, including the DL-333 row's own
citation of the reconnect trigger it rests on (DL-330 → DL-337).
A
> Ledger noteabove the Transport table records the mapping and its cause,matching the existing notes for DL-325 and DL-187..190. The note is the part
that survives: #905's merged commit message and PR body still cite DL-327..330
for these rulings, and neither can be rewritten, so a reader arriving from that
PR or a blame trail resolves the stale numbers through the note.
No ruling text is altered — this is an identifier reconciliation.
Verified: the ledger parses to 304 rows with zero duplicate ids (previously
four),
design-ledger-gatereports OK across 304 rows and 126 record headers,and markdownlint is clean.
Ledger-impact: renumbers DL-327..330 to DL-334..337; no ruling changes.
Refs RIG-3107
Co-authored-by: Matt Wilkinson matt@rigel.build