refactor: Forge owns its checkouts - #1
Merged
Merged
Conversation
start_work(number, branch) allocates the build checkout and returns its path; new finish_work(number) removes it (no-op when never started). Callers never name paths, so the adapter can never rmtree one it didn't create — fixes /retry wiping the checkout via the old workdir='.' path. process_issue owns the create/cleanup bracket; run_once sheds its worktree plumbing. Also: repair verifier runs in the PR worktree (was cwd='.'), and build prompts switch to replace-based substitution (braces in issue bodies crashed .format() before the agent ran). Adapter interface changed — custom adapters need a two-line update. python3 tests/test_devloop.py: all checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes none — part of the architecture review (candidate 1: pull workdir out of the Forge interface).
What
start_work(number, branch) -> strallocates the build checkout and returns its path; newfinish_work(number)removes it (tolerant no-op when the issue never started). Callers never name paths, so the adapter can never rmtree one it didn't create — the old caller-suppliedworkdirparameter let/retryrun with `workdir=".") and have the adapter delete the repo checkout.process_issueowns the create/cleanup bracket (try/finally);run_oncesheds its worktree plumbingcwd=".").format()before the agent ranAdapter impact
Forge adapter interface changed — custom adapters need a two-line update (
start_workreturns the path; addfinish_work). Declare minor at merge per ADR-0002.Verification