refactor: deepen PR-body contract, CLI event bracket, round engine - #6
Merged
Merged
Conversation
added 4 commits
September 16, 2026 21:22
- verify gate: one policy (timeout, PASS semantics) in devloop/gate.py — both copies lacked a timeout, so one hung gate wedged a build thread - review/repair round plumbing (guidance load, thread read, diff cap, LGTM verdict) lives once in devloop/rounds.py; _lgtm twin deleted - devloop branch naming owned by concrete Forge methods, six inline call sites gone - deliver() takes agent_name: str — it only ever read runtime.name devloop: status=none
…se in one module; review_pr takes the Issue, dead branch param deleted
… resolution, parse, silent exit owned once
…ction, announcement, run-failure comment; review/repair keep only what differs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the architecture review (report: /tmp/architecture-review-20260916-212414.html, nothing in-repo). Three deepenings, each reviewed against the design vocabulary; candidate #4 (config agent dispatch) was deliberately skipped — one adapter means a hypothetical seam, revisit at M2.
Commits
_pr_body()template +issue_of_body()parse live indevloop/delivery.py; theCloses #Nmarker (previously written in delivery, regex-parsed in review) has one owner.review_pr()takesissue: Issue | Noneinstead of three optional params; the deadbranchparam is deleted.read_event()owns $GITHUB_EVENT_PATH resolution, read, parse, silent exit;cmd_command/cmd_mergedextract their own fields.rounds.pygainsrun_round(): forge diff fetch + DIFF_CAP +{diff}substitution + fresh PR thread + round announcement + TAIL + run-failure comment, one dialect for review, repair, and repair's verify round. Review keeps prior-findings carry (extra), repair keeps gate→push. Behavior deltas (both cosmetic, nothing parses these comments): thread now read per round (mid-loop human replies get seen), verify announcement is**AI verify, round 1/1**.Verification
python3 tests/test_devloop.py— all checks passed, run after each commit and on this branch tip.