Skip to content

Fix RoaringBitmapIterator use-after-free by retaining its source bitmap #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 1 commit into from
Aug 21, 2026
Merged

Fix RoaringBitmapIterator use-after-free by retaining its source bitmap #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Sources/SwiftRoaring/RoaringBitmap.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ public final class RoaringBitmap: Sequence, Equatable, CustomStringConvertible,
///
@inlinable @inline(__always)
public func makeIterator() -> RoaringBitmapIterator {
return RoaringBitmapIterator(ptr: self.ptr)
return RoaringBitmapIterator(bitmap: self)
}

///
Expand All @@ -939,10 +939,14 @@ public final class RoaringBitmap: Sequence, Equatable, CustomStringConvertible,
@usableFromInline
internal var i: roaring_uint32_iterator_t

@usableFromInline
internal let bitmap: RoaringBitmap

@inlinable @inline(__always)
init(ptr: UnsafePointer<roaring_bitmap_t>) {
init(bitmap: RoaringBitmap) {
self.i = roaring_uint32_iterator_t()
roaring_iterator_init(ptr, &self.i)
roaring_iterator_init(bitmap.ptr, &self.i)
self.bitmap = bitmap
}

@inlinable @inline(__always)
Expand Down
Loading