Repository navigation
fix(security): pin MCP SDK and proxy-addr so production npm audit passes - #57
Merged
Merged
Conversation
Weekly npm audit --omit=dev fails on main: @modelcontextprotocol/sdk 1.30.0 is inside GHSA-6qxp-vccf-f47h (<1.31.0), and express still resolves proxy-addr 2.0.7 (GHSA-jqcg-44mw-7w3h). Bump the direct SDK dependency and override proxy-addr to ^2.0.8 so the production audit is clean. Fixes #43 Fixes #48
Roarpeng
marked this pull request as ready for review
October 7, 2026 09:42
cursor Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
… fix CHANGELOG conflicted after #57. Both Unreleased notes stay: the MCP SDK and proxy-addr override, and closing skill-markdown graph clients. Co-authored-by: RoarPeng <Roarpeng@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
…e fix CHANGELOG conflicted after #57. Both Unreleased notes stay: the MCP SDK and proxy-addr override, and excludeGlobs / streaming dialogue record. Co-authored-by: RoarPeng <Roarpeng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Weekly
npm audit --omit=devon currentmainstill fails, so the goal of #43 and #48 is not met. The original transitive pins (hono,@hono/node-server, body-parser, fast-uri, ip-address, qs, and the transformers 4.x / sharp path) are already onmainvia2b38bcb. Two newer production advisories remain:@modelcontextprotocol/sdk<1.31.0)^1.30.0(locked 1.30.0)^1.32.1proxy-addr<2.0.8)^2.0.7→ 2.0.7^2.0.8The SDK bump is the direct dependency in the root package and
packages/efficiency-agent.proxy-addrstays an override because express has not raised its floor past the vulnerable release.Validation
npm audit --omit=dev— exit 0, 0 vulnerabilitiesnpm run security:audit— exit 0npx vitest run tests/security-audit-script.test.ts— 3 passednpx vitest run tests/mcp-streamable-http.test.ts tests/mcp-http-session-ttl.test.ts tests/mcp-episode-roundtrip.test.ts— 14 passed against SDK 1.32.1Fixes #43
Fixes #48