Spring Cleaning#30
Open
gaymeowing wants to merge 8 commits into
Open
Conversation
* remove ipairs and pairs usage * cleanup load option code a bit by using ternary with a macro function * cleanup log.pretty by using table.concat and removing excessive concat usage * make log use the nocolor argument on richterm formatters * fix log.update not removing the previous line if colorsEnabled is false * stringify varadics correctly in log, as using `or` would lead to only the first value of the varadic being printed * freeze log module
* improve spinner code via using constant modulus instead of `#spinnerChars`, using richterm.combine for spinner coloring, using a macro function for seconds formatting, and making spinnerChars a constant table
…lied on as per luau documentation
* Make runProcess take in a varadic, as it makes for a nicer API
Member
raymondnumbergenerator
left a comment
raymondnumbergenerator
left a comment
There was a problem hiding this comment.
looks good! could you pull the latest changes that bumps to the stable lute release and I'll approve this
raymondnumbergenerator
requested changes
May 13, 2026
|
|
||
| log.info("Rerunning tests using load.version and without optional variables") | ||
|
|
||
| runProcess({ |
There was a problem hiding this comment.
failing from missing the {} here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipairsandpairsusagelog.prettyby usingtable.concatand removing excessive concat operator usagenocolorargument on richterm formatterscolorsEnabledis falseorwould lead to only the first value of the varadic being printedluaGlobalsinjection, now only uses one array instead of 2 as it makes use of;getCallerInfowith a simple ternary that uses thelevelargument todebug.tracebackin the logging utility as the format ofdebug.tracebackshouldn't be relied on.runProcessby removing the unessasarypcall, and making it take in a varadic making its API a bit nicer.#spinnerCharsrichterm.combinefor spinner coloring (helps with readability)