fix(messages): honor db_path in store_artifacts - #848
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
store_artifacts ignored the db_path argument and always read/wrote artifact_database.pkl in the process cwd. Use the provided path for create/load/save and create parent directories when needed. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store_artifactsbuiltPath(db_path)then still opened hardcodedartifact_database.pklin cwd, so custom DB locations never worked.Use the provided path end-to-end and mkdir parents when creating. Tests cover custom path extend + nested dirs.
AI-assisted; human-reviewed.
Claim: bartok
Operator: bartok
Campaign: aerial-drone