Skip to content

fix(ios): stop hijacking UNUserNotificationCenter.delegate #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mr-vishwas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): stop hijacking UNUserNotificationCenter.delegate #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ plugins {

allprojects {
group = "robustrade"
version = "1.14.0"
version = "1.14.2"
}

subprojects {
Expand Down
40 changes: 0 additions & 40 deletions ...ary/src/iosMain/kotlin/ro/cosminmihu/ktor/monitor/ui/notification/NotificationDelegate.kt
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions ...rary/src/iosMain/kotlin/ro/cosminmihu/ktor/monitor/ui/notification/NotificationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,12 @@ import kotlin.coroutines.resume

internal actual class NotificationManager {

private val notificationCenter = UNUserNotificationCenter.currentNotificationCenter().apply {
setDelegate(NotificationDelegate(appNotificationDelegate = delegate()))
}
// The library deliberately does not touch UNUserNotificationCenter.delegate. That property is
// the host app's, it is weak (so anything installed here has to be kept alive), and taking it
// over displaces whatever the app or its SDKs installed — which silently breaks push handling,
// deep links included. The notification below is still delivered to Notification Center; it is
// simply not presented as a banner while the app is in the foreground.
private val notificationCenter = UNUserNotificationCenter.currentNotificationCenter()

actual suspend fun clear() {
notificationCenter.removePendingNotificationRequestsWithIdentifiers(listOf(NOTIFICATION_ID.toString()))
Expand Down