feat(post-processing): admin scaffolding precursor (pydantic schema, form base, parameterized template) by mihow · Pull Request #1289 · RolnickLab/antenna

mihow · 2026-05-01T22:08:51Z

Summary

Precursor PR for post-processing admin work. Extracts the shared admin-trigger pattern that PRs #999 (class masking) and #1272 (tracking) each grew independently, using SmallSizeFilterTask as the migration consumer.

No new domain logic. Pure scaffolding + a refactor of the existing small-size-filter trigger to expose its already-coded size_threshold knob via the admin (currently unreachable — admin trigger hardcodes empty config).

What lands

config_schema contract on BasePostProcessingTask — pydantic v1 model required as a class attribute, validated at task __init__
BasePostProcessingActionForm — django form base with to_config() → dict contract for building Job.params['config']
Parameterized confirmation template at admin/post_processing/confirmation.html + _form_fieldset.html partial
Migrated SmallSizeFilterTask:
- SmallSizeFilterConfig(size_threshold: float = 0.0008, source_image_collection_id: int) schema
- SmallSizeFilterActionForm with size_threshold field (0 < x < 1 validation)
- Admin trigger rewrites onto new pattern (intermediate confirmation page)
- Default behavior preserved (same 0.0008 default)
17 tests under ami/ml/post_processing/tests/

Out of scope (deferred to follow-ups)

Project-partitioning helper (defer to whichever multi-scope adopter lands first — likely feat(tracking): revive occurrence tracking as a post-processing task #1272's tracking, which partitions events across projects)
REST API surface (eventual primary trigger; admin not future-primary)
Rank rollup, class masking, tracking — they stay in their own PRs

Rebase impact for downstream PRs

feat(tracking): revive occurrence tracking as a post-processing task #1272 (tracking, mine): smaller diff after rebase. admin_forms.py → admin/tracking_form.py. Form gains to_config(). Adds TrackingConfig schema. Per-project partition loop stays.
Implement class masking using the post-processing framework #999 (class masking, @mohamedelabbas1996): hand-rolled HTML <select> becomes ClassMaskingActionForm(BasePostProcessingActionForm) with ModelChoiceFields. Adds ClassMaskingConfig + RankRollupConfig schemas. Will message author once this lands.

Smoke test (manual, against live stack)

End-to-end validated against project 18 capture set 175 (10 images):

Action dropdown lists "Run Small Size Filter post-processing task (async)" ✓
Click Go → renders intermediate confirmation page (template admin/post_processing/confirmation.html rendered) ✓
Form shows size_threshold field with default 0.0008 and help text ✓

Submit → redirect with success message; Job 1571 created and enqueued; celeryworker picked up; ran to SUCCESS ✓
Job.params payload validated typed: {'task': 'small_size_filter', 'config': {'size_threshold': 0.0008, 'source_image_collection_id': 175}} ✓

Test plan

test_base_schema.py — subclass without schema raises, bad config raises ValidationError, valid config builds BaseModel instance, unknown keys rejected (extra="forbid")
test_admin_form.py — to_config() round-trip, size_threshold range validation
test_small_size_filter_admin.py — POST without confirm renders intermediate page (no Job created), POST with valid confirm=yes creates one Job per collection with threshold in config, invalid threshold re-renders form with error, multi-collection POST creates per-collection jobs with correct project FKs
Manual smoke: trigger from Django admin against existing test data; verify Job runs to completion with custom threshold

Design doc

docs/claude/planning/2026-05-01-post-processing-admin-scaffolding-design.md (committed in this branch).

Notes

Pydantic v1 syntax throughout (repo pins pydantic<2.0).
Pyright will surface __fields__ and validator as deprecated in some envs — these come from local v2 stubs; container is v1 and the syntax is correct.

Context: PRs #999 (class masking) and #1272 (tracking) each grew their own admin-trigger plumbing (registry registration, intermediate confirmation page with form, freeform dict config). This precursor extracts the shared pattern using SmallSizeFilterTask as the migration consumer — proves the abstraction without carving up another contributor's open PR. Spec covers: pydantic config_schema contract on BasePostProcessingTask, BasePostProcessingActionForm class, parameterized confirmation template + partial, SmallSizeFilterTask migration (exposes existing size_threshold knob via admin), test plan, rebase impact for #999 + #1272. Co-Authored-By: Claude <noreply@anthropic.com>

netlify · 2026-05-01T22:08:55Z

✅ Deploy Preview for antenna-preview canceled.

Name	Link
🔨 Latest commit	`a1c8600`
🔍 Latest deploy log	https://app.netlify.com/projects/antenna-preview/deploys/69f52704678d98000856df61

netlify · 2026-05-01T22:08:55Z

✅ Deploy Preview for antenna-ssec canceled.

Name	Link
🔨 Latest commit	`a1c8600`
🔍 Latest deploy log	https://app.netlify.com/projects/antenna-ssec/deploys/69f52704b06ff400080794c4

coderabbitai · 2026-05-01T22:08:58Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 47c908d6-fc3b-4dcf-8de3-fa7954cb301e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/post-processing-admin-scaffolding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Adds the shared infrastructure that PRs #999 (class masking) and #1272 (tracking) each grew independently. Uses SmallSizeFilterTask as the migration consumer to prove the pattern without carving up another open PR. Changes: - BasePostProcessingTask gains required pydantic config_schema class attr; validates Job.params['config'] at task __init__ via self.config_schema(**config). self.config is now a BaseModel instance (was: freeform dict). - SmallSizeFilterTask: adds SmallSizeFilterConfig schema (size_threshold + source_image_collection_id, validators for 0<x<1, extra=forbid). Existing default 0.0008 preserved. - New admin form base BasePostProcessingActionForm with to_config() contract, plus SmallSizeFilterActionForm exposing size_threshold knob (currently unreachable — admin trigger hardcoded empty config). - Parameterized confirmation template at admin/post_processing/confirmation.html with overridable {% block intro %} and a _form_fieldset.html partial. - run_small_size_filter admin action rewrites onto new pattern: intermediate confirmation page on first POST, validate + enqueue on confirm. Per-collection Job creation preserved (each Job gets correct project FK). - 17 tests covering schema contract, form validation, intermediate page render, multi-collection partitioning by project FK. Pydantic v1 syntax throughout (repo pins pydantic<2.0). Memory note: container is v1, .dict() / .__fields__ are correct here. Out of scope (explicitly deferred): - Project-partitioning helper (defer to whichever multi-scope adopter lands first, likely #1272's tracking which partitions events across projects) - REST API trigger surface (eventual primary; admin not future-primary) - Rank rollup, class masking, tracking tasks themselves — stay in their PRs Design doc: docs/claude/planning/2026-05-01-post-processing-admin-scaffolding-design.md Co-Authored-By: Claude <noreply@anthropic.com>

Confirmation page (intermediate page rendering with size_threshold form field) and success message (after submitting form, Job 1571 enqueued with typed config payload). Co-Authored-By: Claude <noreply@anthropic.com>

mihow · 2026-05-11T20:50:18Z

-            jobs.append(job.pk)
-
-        self.message_user(request, f"Queued Small Size Filter for {queryset.count()} capture set(s). Jobs: {jobs}")
+    def run_small_size_filter(


If we add 2 to 3 more post processing methods, this function may start to look repetitive. Is it worth trying to abstract run_... and _render ? I already see some repeated strings in this single implementation.

mihow and others added 2 commits May 1, 2026 15:13

docs(post-processing): add PR #1289 admin smoke screenshots

a1c8600

Confirmation page (intermediate page rendering with size_threshold form field) and success message (after submitting form, Job 1571 enqueued with typed config payload). Co-Authored-By: Claude <noreply@anthropic.com>

mihow commented May 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(post-processing): admin scaffolding precursor (pydantic schema, form base, parameterized template)#1289

feat(post-processing): admin scaffolding precursor (pydantic schema, form base, parameterized template)#1289
mihow wants to merge 3 commits into
mainfrom
feat/post-processing-admin-scaffolding

mihow commented May 1, 2026 •

edited

Loading

Uh oh!

netlify Bot commented May 1, 2026 •

edited

Loading

Uh oh!

netlify Bot commented May 1, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 1, 2026 •

edited

Loading

Review skipped

Uh oh!

mihow May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mihow commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What lands

Out of scope (deferred to follow-ups)

Rebase impact for downstream PRs

Smoke test (manual, against live stack)

Test plan

Design doc

Notes

Uh oh!

netlify Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for antenna-preview canceled.

Uh oh!

netlify Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for antenna-ssec canceled.

Uh oh!

coderabbitai Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

mihow May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mihow commented May 1, 2026 •

edited

Loading

netlify Bot commented May 1, 2026 •

edited

Loading

netlify Bot commented May 1, 2026 •

edited

Loading

coderabbitai Bot commented May 1, 2026 •

edited

Loading