feat: add lock API config toggle to Settings providers tab#12241
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
feat: add lock API config toggle to Settings providers tab#12241roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
Adds a "Use the same API configuration for all modes" checkbox to the Providers section in Settings, making the existing lockApiConfigAcrossModes feature discoverable without needing to find the small lock icon inside the API Configuration popover. - Adds VSCodeCheckbox to SettingsView providers tab bound to cachedState - Sends lockApiConfigAcrossModes message on save (same handler as popover) - Adds i18n strings for the label and description - Adds test coverage for rendering, toggling, and save behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12237
Description
This PR attempts to address Issue #12237 by making the existing
lockApiConfigAcrossModesfeature more discoverable. The lock icon inside the API Configuration popover is hard to find (and may not be visible in some versions). This adds a checkbox labeled "Use the same API configuration for all modes" directly to the Providers section in the Settings view.How it works:
VSCodeCheckboxto the providers tab inSettingsView.tsx, placed between the API config profile selector and the provider optionslockApiConfigAcrossModesstate incachedStatelockApiConfigAcrossModesmessage that the popover lock icon uses, so no backend changes are neededsettings.jsonlocaleThis is purely additive -- the existing lock icon in the API Configuration popover continues to work as-is.
Feedback and guidance are welcome.
Test Procedure
SettingsView.lockApiConfig.spec.tsxwith 5 tests covering rendering, toggling, and save behaviorSettingsView.spec.tsxtests (16/16) still passChatTextArea.lockApiConfig.spec.tsxtests (5/5) still passManual testing:
Pre-Submission Checklist
Documentation Updates
No documentation changes needed. The checkbox label and description text are self-explanatory.
Interactively review PR in Roo Code Cloud