[Feat] Let agents call HTTP integrations without handling credentials - #2384
Open
roomote-roomote[bot] wants to merge 7 commits into
Open
[Feat] Let agents call HTTP integrations without handling credentials#2384roomote-roomote[bot] wants to merge 7 commits into
roomote-roomote[bot] wants to merge 7 commits into
Conversation
Contributor
|
No new code issues found. See task
Reviewed b732e37 |
Contributor
Author
|
Fixed the reported custom MCP name collision in d1a7c7f7 and resolved its review thread. The built-in broker now uses a reserved ID outside the valid custom-server namespace. Existing custom MCPs named 227 focused tests passed, along with affected-package type checks, docs checks, and all pre-push gates. PR metadata is refreshed. The automatic Roomote re-review and full CI test job are still in progress; their success is not yet claimed. No live provider or production changes were made. |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 9, 2026 15:37
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add opt-in HTTP integrations for Fast sessions and sandbox agents through the same Roomote API and actor-access rules. Agents choose a configured integration, method, path, and request body. The API retrieves an environment-referenced credential server-side, attaches authentication, and forwards HTTPS without exposing credentials in agent configuration or tool listings.
_roomote_http_integrations, its server wins and the generated broker is omitted with a warning. Rename the operator server to receive both; Fast is unaffected.isErrorbefore payload extraction so denied tool calls enter Fast's failed audit path. Preserve successful payload behavior and avoid copying upstream error contents into the new error.Enable with
R_HTTP_INTEGRATIONS_ENABLED=true; supplyR_HTTP_INTEGRATIONS_CONFIG_PATHand credential variables only to the API. OmittingallowedUserIdsshares an integration with active human members. Actorless service runs are rejected. Manifest grants are startup snapshots: removal requires API reload/restart, not immediate revocation. This is not Session-scoped authorization.Existing OAuth/inference flows and normal networking remain unchanged. There is no iron-proxy dependency, global proxy setting, provider-specific egress change, or hard network isolation.
How it was tested
Final tested head:
e8c623e309c78928fc47929a97b9ca8efea8f86b.pnpm lint:fast,pnpm format:check,pnpm check-types:fast(27 packages),pnpm knip, and normal commit/pre-push hooks passed. Worker and cloud-agents full package type checks passed. The worker release archive was rebuilt with this exact embedded commit.Full product readiness remains unverified. Two model-driven Fast attempts stopped at an acknowledgement/subagent-context guard before the broker call. One fresh task was accepted by the local API but failed with
docker_daemon_unreachablebefore worker execution. Thus successful model-driven Fast and fresh-sandbox authenticated requests are not claimed. No production changes or deployments were made.The initial implementation and earlier compatibility fixes also passed their documented API, SDK, types, worker, Fast, and docs suites. The local TLS unit test explicitly allows its loopback fixture; the separate live smoke does not mock DNS/TLS or upstream authentication.
Response reflection detection is literal, not general DLP. Operators must exclude credential-echo/debug endpoints and APIs that expand authority through query/body parameters. Initial support is one environment-backed auth header and bounded UTF-8 text/JSON, not OAuth refresh, private-network targets, streaming, or arbitrary headers.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally (formatting/full lint and the repository's fast type-check gate passed; exact commands are listed above)pnpm changeset