[Improve] Restore environment skill management - #2424
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
[Improve] Restore environment skill management#2424roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 9, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The integration overlap is limited to
SkillsSettingsPage.tsxand its existingInstanceSkills.client.test.tsx; the environment management component and tests are separate new files.Why this change was made
The shared instance-wide catalog should remain the primary Skills experience, while admins still need a low-prominence UI for managing legacy environment-scoped playbooks. This restores the manual management portion of the earlier collapsed disclosure without reviving its marketplace coupling.
Impact
Admins can manage persisted
manualSkillsacross selected environments from Settings again, including on mobile. Members continue to see only the shared instance catalog. Existing backend authorization, environment YAML persistence, runtime loading, and marketplace behavior are unchanged.Focused client tests, web type checks, docs validation, formatting, lint, fast monorepo type checks, knip, and the full pre-push hooks pass. Browser validation used a genuine local admin and form-created environment skill at desktop and 390px mobile widths; no horizontal overflow was present. The environment skill runtime loading path was not re-tested end to end because it was not changed.
Screenshots
Collapsed environment section on desktop:
Expanded environment management after creating a skill:
Expanded environment management on mobile:
Environment skill editor on mobile: