Skip to content

[Fix] Cost totals drop when users delete tasks #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
+110 −13
Open

[Fix] Cost totals drop when users delete tasks #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions apps/web/src/lib/server/analytics/cost-rows.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 26 additions & 13 deletions apps/web/src/lib/server/analytics/cost-rows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export async function getCostAnalyticsRows(
modelId: llmUsageEvents.modelId,
environmentName: environments.name,
taskTitle: tasks.title,
taskDeletedAt: tasks.deletedAt,
initiatorKind: tasks.initiatorKind,
initiatorAutomation: tasks.initiatorAutomation,
actorDisplayName: tasks.actorDisplayName,
Expand All @@ -148,7 +149,7 @@ export async function getCostAnalyticsRows(
)
.leftJoin(taskRuns, eq(taskRuns.id, llmUsageEvents.runId))
.leftJoin(environments, eq(environments.id, llmUsageEvents.environmentId))
.where(and(isNull(tasks.deletedAt), usageCutoffCondition));
.where(usageCutoffCondition);

const fallbackEnvironmentIds = [
...new Set(
Expand Down Expand Up @@ -249,23 +250,30 @@ export async function getCostAnalyticsRows(

return usageRows.map((row) => {
const isTask = Boolean(row.taskId);
const isDeletedTask = isTask && Boolean(row.taskDeletedAt);
const isMemory = !isTask && row.source === 'brain_synthesis';
const isSession =
!isTask &&
!isMemory &&
fastNativeSessionIds.has(row.harnessSessionId ?? '');
const taskType = isTask
? getTaskTypeDimensionValue({
initiatorKind: row.initiatorKind,
initiatorAutomation: row.initiatorAutomation,
actorDisplayName: row.actorDisplayName,
})
: createLabelBackedDimensionValue(
isMemory ? 'Memories' : isSession ? 'Session' : 'Non-task inference',
);
const taskType = isDeletedTask
? createLabelBackedDimensionValue('Deleted task')
: isTask
? getTaskTypeDimensionValue({
initiatorKind: row.initiatorKind,
initiatorAutomation: row.initiatorAutomation,
actorDisplayName: row.actorDisplayName,
})
: createLabelBackedDimensionValue(
isMemory
? 'Memories'
: isSession
? 'Session'
: 'Non-task inference',
);
const attributedUserId = row.userId ?? row.taskUserId;
const userDimension =
isTask && row.initiatorKind === 'automation'
isDeletedTask || (isTask && row.initiatorKind === 'automation')
? createLabelBackedDimensionValue(NO_VALUE_LABEL)
: attributedUserId
? getCanonicalUserDimensionValue({
Expand Down Expand Up @@ -309,9 +317,14 @@ export async function getCostAnalyticsRows(
model,
cost: cost.toFixed(2),
tokens: String(tokens),
taskTitle: row.taskTitle ?? taskType.label,
taskTitle: isDeletedTask
? taskType.label
: (row.taskTitle ?? taskType.label),
},
links: row.taskId ? { task: `/task/${row.taskId}` } : undefined,
links:
row.taskId && !isDeletedTask
? { task: `/task/${row.taskId}` }
: undefined,
},
meta: {
canonicalTaskId: row.taskId,
Expand Down
Loading