[Fix] Suggested tasks leave the automation Slack thread when accepted - #2440
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
[Fix] Suggested tasks leave the automation Slack thread when accepted#2440roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 10, 2026 03:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
A scheduled automation could successfully publish suggestion cards even when its post-publication Session-to-Slack binding failed. Accepting one of those cards then kept the work in the automation Session but seeded a new Slack root because the Session had no usable Slack reply target.
The precise trigger for the observed missing binding was not confirmed, so this fixes the unsafe success state rather than assuming a specific historical failure.
Impact
New task-backed automation suggestions retain canonical Session provenance on the card and cannot complete publication without a matching Slack thread binding. Transient binding failures can be retried idempotently against the already-posted report. Existing historical cards are not backfilled, and Slack delivery remains outside the database transaction.